The converting process has been started.
It has been converted.
With preprocess, I'm thinking something more like this. However, it seems I couldn't find a 'local task' this affects - the primary nav and the tabs for a node, for example, don't seem to be affected by this. Can anyone confirm this patch works for Stark?
Tested with Stark, works for me except one notice:
Notice: Indirect modification of overloaded element of Drupal\Core\Template\Attribute has no effect in template_preprocess_menu_local_task() (line 1682 of core/includes/menu.inc).
I'v fixed this according to the annotations in Drupal\Core\Template\Attribute.
Tested killerpoke's patch. PHP notice is gone now and rest looks good.
One small notice: inactive menu tasks have an empty class attribute now, but that's actually a different topic.
Updating title, tags; assigning myself.
Closing this (instead of moving it to core queue) in favor of aggregated 'menu.inc' core issue #1898478: menu.inc - Convert theme_ functions to Twig. Git attributions to all participants will happen there.
Automatically closed -- issue fixed for 2 weeks with no activity.
This issue has no child issues.
Drupal is a registered trademark of Dries Buytaert.