These should pass on 7.x, and we can then backport to 6.x to hopefully fix #1798484: Product kit miscalcuation of discounts and total price changes every time saved

Files: 
CommentFileSizeAuthor
#12 1840260-kit-default-qty-d6.patch1.34 KBlongwave
PASSED: [[SimpleTest]]: [MySQL] 2,062 pass(es).
[ View ]
#11 1840260-kit-default-qty-11.patch2.77 KBlongwave
PASSED: [[SimpleTest]]: [MySQL] 2,685 pass(es).
[ View ]
#9 1840260-kit-default-qty.patch1.86 KBlongwave
FAILED: [[SimpleTest]]: [MySQL] 2,685 pass(es), 0 fail(s), and 5 exception(s).
[ View ]
#9 1840260-kit-default-qty-tests-only.patch1.36 KBlongwave
FAILED: [[SimpleTest]]: [MySQL] 2,682 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#7 1840260-uc_product_kit-tests-d6-7.patch11.06 KBlongwave
PASSED: [[SimpleTest]]: [MySQL] 2,063 pass(es).
[ View ]
#4 1840260-uc_product_kit-tests-d6-4.patch11.03 KBlongwave
FAILED: [[SimpleTest]]: [MySQL] 2,055 pass(es), 4 fail(s), and 0 exception(s).
[ View ]
#2 1840260-uc_product_kit-tests-d6.patch8.64 KBlongwave
FAILED: [[SimpleTest]]: [MySQL] 2,059 pass(es), 4 fail(s), and 43 exception(s).
[ View ]
uc_product_kit-tests.patch9.12 KBlongwave
PASSED: [[SimpleTest]]: [MySQL] 2,682 pass(es).
[ View ]

Comments

longwave’s picture

Version:7.x-3.x-dev» 6.x-2.x-dev
Status:Needs review» Patch (to be ported)

Committed.

longwave’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new8.64 KB
FAILED: [[SimpleTest]]: [MySQL] 2,059 pass(es), 4 fail(s), and 43 exception(s).
[ View ]

I don't think this is going to prove what I expected it to prove.

Status:Needs review» Needs work

The last submitted patch, 1840260-uc_product_kit-tests-d6.patch, failed testing.

longwave’s picture

Status:Needs work» Needs review
StatusFileSize
new11.03 KB
FAILED: [[SimpleTest]]: [MySQL] 2,055 pass(es), 4 fail(s), and 0 exception(s).
[ View ]

This should fix the above failures and exceptions. There's a handful of seemingly harmless warnings, but it does appear that the default quantity field on new product kits has never worked in 6.x, and looking at 7.x it seems we do the wrong thing there as well; I guess nobody uses this feature enough to notice.

Status:Needs review» Needs work

The last submitted patch, 1840260-uc_product_kit-tests-d6-4.patch, failed testing.

longwave’s picture

Hmm. That doesn't happen when I run the tests locally.

longwave’s picture

Status:Needs work» Needs review
StatusFileSize
new11.06 KB
PASSED: [[SimpleTest]]: [MySQL] 2,063 pass(es).
[ View ]

So assertFieldByName() works slightly differently on select elements in D6 and D7.

longwave’s picture

Status:Needs review» Active

Committed #7. Back to active, to add more tests for default quantity.

longwave’s picture

Version:6.x-2.x-dev» 7.x-3.x-dev
Status:Active» Needs review
StatusFileSize
new1.36 KB
FAILED: [[SimpleTest]]: [MySQL] 2,682 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
new1.86 KB
FAILED: [[SimpleTest]]: [MySQL] 2,685 pass(es), 0 fail(s), and 5 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1840260-kit-default-qty-tests-only.patch, failed testing.

longwave’s picture

Status:Needs work» Needs review
StatusFileSize
new2.77 KB
PASSED: [[SimpleTest]]: [MySQL] 2,685 pass(es).
[ View ]
longwave’s picture

Version:7.x-3.x-dev» 6.x-2.x-dev
StatusFileSize
new1.34 KB
PASSED: [[SimpleTest]]: [MySQL] 2,062 pass(es).
[ View ]

Committed #11.

longwave’s picture

Status:Needs review» Fixed

Committed #12.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.