Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hi,
In 2.0.4 release notes it is mentioned, that httprl module support is dorpped.
Does it mean if I install this module manually, from platform source, not o_contrib it won't work anyway?
Btw, the last dev of this module is today, so is it really not supported? Or maybe performance benefits are too low?
Comment | File | Size | Author |
---|---|---|---|
#17 | httprl-1837776-17-update-readme.patch | 4.23 KB | mikeytown2 |
#14 | httprl-1837776-14-add-host.patch | 550 bytes | mikeytown2 |
Comments
Comment #1
omega8cc CreditAttribution: omega8cc commentedIt caused too many issues for us with no real benefits, so we no longer include it. There is nothing related/forced in the BOA configuration, so you could try to use it as any other module, if you wish.
Comment #2
omega8cc CreditAttribution: omega8cc commentedOops, it seems that we now force it as disabled after too serious issues reported, so you would need to modify
/var/xdrago/usage.sh
script to avoid having it disabled every morning.Comment #3
omega8cc CreditAttribution: omega8cc commentedI think that we shouldn't force it as disabled for everybody.
Comment #4
omega8cc CreditAttribution: omega8cc commentedFixed in HEAD and stable: http://drupalcode.org/project/octopus.git/commit/86cbe8b
Comment #5
mikeytown2 CreditAttribution: mikeytown2 commentedJust curious, what are some of the reported issues with httprl? I can't fix what I don't know :)
Comment #6
mikeytown2 CreditAttribution: mikeytown2 commentedComment #7
mikeytown2 CreditAttribution: mikeytown2 commentedneed more info for this bug report
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedClosing issue as no new info has been given. Re-open if you have more info.
Comment #9
omega8cc CreditAttribution: omega8cc commentedI have requested some feedback/details from our users who reported the "issues" in the past, but I guess it will take some time to collect these reports, sorry for the delay here.
Comment #10
mikeytown2 CreditAttribution: mikeytown2 commentedThanks for the update :)
I'll move this back to postponed.
Comment #11
hass CreditAttribution: hass commentedI would also like to hear what type of problems are in httprl.
Comment #12
mikeytown2 CreditAttribution: mikeytown2 commentedIt's been almost a month. Any news on what might have been the reported issue?
Comment #13
omega8cc CreditAttribution: omega8cc commentedI would love to submit complete report with steps to reproduce issues, but I guess it is not the best time in the year to expect fast response from people, and so far I have received only reports about redirect loops and sending requests to the wrong vhost in Nginx etc. I still need more details to determine if it was really the module issue, Nginx config fault, user side wrong configuration or something else. I need some steps to reproduce the problem, so I can offer better feedback.
Comment #14
mikeytown2 CreditAttribution: mikeytown2 commentedBased off the limited information given I think I found the bug. The report would have to do with a multisite and/or multiple drupal installs behind one IP. When issuing a background request and the httprl_server_addr variable is set to an IP the host is also set to that IP. Thus who ever gets served when no hostname is set would get a lot of requests.
The following patch has been committed. Setting to active as I need to do some followup to this.
Comment #15
mikeytown2 CreditAttribution: mikeytown2 commentedComment #16
omega8cc CreditAttribution: omega8cc commentedThat sounds similar to the other issue we have had with AdvAgg in the past: #1142990: Why SERVER_ADDR is used instead of HTTP_HOST to build $url in function advagg_css_js_file_builder() ?
I will give it a try. Thanks!
Comment #17
mikeytown2 CreditAttribution: mikeytown2 commentedCodewise I thought there would be more to do in this case. Pretty sure the patch in #14 covers everything. I've revamped the readme though and its usage of httprl_build_url_self().
The following patch has been committed.