Add Custom Paths

$ curl http://drupal.org/files/fixes_to_apply.patch | git apply
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 9127 100 9127 0 0 14654 0 --:--:-- --:--:-- --:--:-- 19585
:88: trailing whitespace.

:143: trailing whitespace.
$edit_path = str_replace('%', $id, $crud_info['edit']['path']);
:145: trailing whitespace.
'title' => t('edit'),
:146: trailing whitespace.
'href' => $edit_path,
:158: trailing whitespace.
'title' => t('delete'),
error: patch failed: eck.bundle.inc:244
error: eck.bundle.inc: patch does not apply
error: patch failed: eck.entity.inc:152
error: eck.entity.inc: patch does not apply

there has been no changes to the 7.x branch since the creation of the change_path branch, so it should be safe to change to that branch and apply the patch until I get some time to merge things.

@webadpro I know that you probably been one of the few that have actually used this patch extensively, how useful have you found being able to change the page of every entity action (delete, view, edit)? It seems to me like most of the time you only care to move the list and possibly the view, but delete and edit will go with it. Your input is greatly appreciated.

the change_paths branch now has the last patch, plus it has been merged with the last commits from 7.x-2.x

One of the things that I enjoy about using eck is that it is pretty straight forward to navigate through all the information. This new code kind of breaks the pattern of navigation. Currently, every time you click on an entity type, or bundle name, you end up in a list, but with the patch clicking on a bundle name makes you end in the edit form, instead of the list of entities of that bundle. I understand why this was done, now that we can move that whole section around (the bundle management section), it seems more appropriate to end up in a place were you are dealing with bundles and not with entities. I want to attempt to fix that, in a way that moving things around works as designed in the patch, but that when nothing is moved, the navigation experience stays as is.

The other thing that I would like to change before committing this work is the db update. The db update has already been written, and from my test it works well, but I think that we can eliminate the need for that db update, simply by putting a little logic that uses default paths if no custom paths have been set. In my opinion if a db update is not absolutely necessary, it is better not to have one.

I will be reporting as I get this work done, feel free to point out any objections on the proposed changes.

@webadpro thanks, that is exactly what I was thinking

Ok, I just got the two things mentioned done, they are in the branch, but I noticed that the edit and delete paths were not being respected, they just followed the view path around. I did not mess with the code that creates those paths, so I am not sure what the original behaviour, or what the intended behaviour is supposed to be.

@webadpro: if you have a few minutes to review, I will appreciate it

Sorry, I have been trying to push 3.x out the door, but I have been thinking about this issue a lot. I am not sure that I like the current solution, maybe we should get on irc and talk about it :)

Supporting this request: To create custom add and edit paths per entity will be very useful.

Cheering on first formal 3.x release!

Closing this issue because 7.x-3.x is unsupported. See #2495527: 3.x Roadmap: Unsupported, do NOT use

Please reopen the issue and move it to the 7.x-2.x branch if it is still/also relevant in 7.x-2.x.