If a module provides default config for another module, like node module shipping a view (#1806334: Replace the node listing at /node with a view), the config will be loaded regardless of whether or not node is enabled.
Currently, Views works around this by manually storing a key in the config and calling module_exists().

However, this will apply to all config entity types, and this tries to genericize and automate this.

I need to write some tests to provide this is broken.

Files: 
CommentFileSizeAuthor
#8 vdc-1830716-7.patch7.75 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 46,249 pass(es), 440 fail(s), and 122 exception(s). View
#2 drupal-1830716-2-FAIL.patch3.14 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 46,891 pass(es), 1 fail(s), and 0 exception(s). View
#2 drupal-1830716-2-PASS.patch7.99 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1830716-2-PASS.patch. Unable to apply patch. See the log in the details link for more information. View
#1 drupal-1830716-1.patch4.86 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 45,397 pass(es), 657 fail(s), and 124 exception(s). View

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
4.86 KB
FAILED: [[SimpleTest]]: [MySQL] 45,397 pass(es), 657 fail(s), and 124 exception(s). View

I'm curious to see if this breaks non-ConfigEntity config.

tim.plunkett’s picture

Issue tags: -Needs tests
FileSize
7.99 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1830716-2-PASS.patch. Unable to apply patch. See the log in the details link for more information. View
3.14 KB
FAILED: [[SimpleTest]]: [MySQL] 46,891 pass(es), 1 fail(s), and 0 exception(s). View

Here's a test.

Status: Needs review » Needs work
Issue tags: -Configuration system, -VDC, -Configurables

The last submitted patch, drupal-1830716-2-PASS.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review

#2: drupal-1830716-2-PASS.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal-1830716-2-PASS.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review

#2: drupal-1830716-2-PASS.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Configuration system, +VDC, +Configurables

The last submitted patch, drupal-1830716-2-PASS.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
7.75 KB
FAILED: [[SimpleTest]]: [MySQL] 46,249 pass(es), 440 fail(s), and 122 exception(s). View

Status: Needs review » Needs work

The last submitted patch, vdc-1830716-7.patch, failed testing.

tim.plunkett’s picture

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned
Status: Postponed » Closed (duplicate)