This is a sub-task of http://drupal.org/node/1775842 Convert all variables to state and/or config systems.

Files: 
CommentFileSizeAuthor
#23 1824898-weight_select_max_to_config-drupal8-23.patch420 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 49,444 pass(es). View
#21 1824898-weight_select_max_to_config-drupal8-21.patch651 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 49,433 pass(es). View
#18 1824898-weight_select_max_to_config-drupal8-18.patch651 bytesACF
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/system.install. View
#12 1824898-drupal_weight_select_max-cmi-12.patch2.06 KBACF
PASSED: [[SimpleTest]]: [MySQL] 48,985 pass(es). View
#10 1824898-drupal_weight_select_max-cmi-10.patch1.57 KBACF
FAILED: [[SimpleTest]]: [MySQL] 48,448 pass(es), 5 fail(s), and 40,547 exception(s). View
#7 1824898-drupal_weight_select_max-cmi-3.patch2.08 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 46,314 pass(es), 2 fail(s), and 0 exception(s). View
#6 1824898-drupal_weight_select_max-cmi-2.patch2.08 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 46,314 pass(es), 0 fail(s), and 42 exception(s). View
#1 1824898-drupal_weight_select_max-cmi-1.patch1.22 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 46,315 pass(es). View

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
1.22 KB
PASSED: [[SimpleTest]]: [MySQL] 46,315 pass(es). View
vijaycs85’s picture

Status: Needs review » Needs work
Issue tags: -State system

The last submitted patch, 1824898-drupal_weight_select_max-cmi-1.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
Issue tags: +State system
alexpott’s picture

Status: Needs review » Needs work
Issue tags: -State system +Configuration system

drupal_weight_select_max should be configuration and not state. So we to add this to system.site.yml etc..

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
2.08 KB
FAILED: [[SimpleTest]]: [MySQL] 46,314 pass(es), 0 fail(s), and 42 exception(s). View

Thanks for the review Alex. Just changed it as config.

vijaycs85’s picture

FileSize
2.08 KB
FAILED: [[SimpleTest]]: [MySQL] 46,314 pass(es), 2 fail(s), and 0 exception(s). View

Missed to change the upgrade hook. Here is the fixed one.

Status: Needs review » Needs work

The last submitted patch, 1824898-drupal_weight_select_max-cmi-3.patch, failed testing.

alexpott’s picture

Status: Needs work » Postponed

The failures are due to an issue with update_variables_to_config(). This is now postposed on #1825466: Allow NestedArray::mergeDeepArray() to preserve integer keys

ACF’s picture

Status: Postponed » Needs review
FileSize
1.57 KB
FAILED: [[SimpleTest]]: [MySQL] 48,448 pass(es), 5 fail(s), and 40,547 exception(s). View

reroll of the patch by vijaycs85, Not sure about the naming of the variable weight_select_max, wonder if it could be something a bit more descriptive.

longwave’s picture

Title: Covert drupal_weight_select_max variable to CMI system » Convert drupal_weight_select_max variable to CMI system
Status: Needs review » Needs work

config(system.site) is missing quotes.

The DRUPAL_WEIGHT_SELECT_MAX constant is now redundant and can be deleted as well.

ACF’s picture

Status: Needs work » Needs review
FileSize
2.06 KB
PASSED: [[SimpleTest]]: [MySQL] 48,985 pass(es). View

Try again, silly mistake.

heyrocker’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me if the bot comes back green

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

swentel’s picture

Status: Fixed » Needs work

I think more was pushed than intented, see http://drupalcode.org/project/drupal.git/commit/cd8dd17

yched’s picture

Yup, some EFQ code got in as well in the same commit :-)

catch’s picture

Rolled this back so we can get a cleaner commit history. Also there's a conflict with the update functions so it'll need a re-roll.

ACF’s picture

Status: Needs work » Needs review
FileSize
651 bytes
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/system.install. View

Updated the system.install.

aspilicious’s picture

Status: Needs review » Needs work
Issue tags: +Configuration system

The last submitted patch, 1824898-weight_select_max_to_config-drupal8-18.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
651 bytes
PASSED: [[SimpleTest]]: [MySQL] 49,433 pass(es). View

re-rolling with update_N

ACF’s picture

Status: Needs review » Needs work

I think that it is easier rather than always updating the system.install update number to just add the variable it to another system.site update, partiularly as that is what is going to happen eventually anyway.

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
420 bytes
PASSED: [[SimpleTest]]: [MySQL] 49,444 pass(es). View

I'm happy to do it :)

aspilicious’s picture

I'm confused are the actual .yml changes already comitted? According to catch it seems everything is reverted. So we have to recreate the patch.

vijaycs85’s picture

yeah, except hook_update_N, other changes in patch at #12 is already in core.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Ok lets go for it than :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Hopefully I didn't screw it up this time. ;)

Automatically closed -- issue fixed for 2 weeks with no activity.

vijaycs85’s picture

Assigned: vijaycs85 » Unassigned
Issue summary: View changes
sun’s picture