Files: 
CommentFileSizeAuthor
#6 1824712-open_id-convert_xri_proxy_resolver-5.patch2.66 KBCameron Tod
PASSED: [[SimpleTest]]: [MySQL] 46,247 pass(es). View
#6 interdiff.txt184 bytesCameron Tod
#5 1824712-open_id-convert_xri_proxy_resolver-4.patch2.66 KBCameron Tod
PASSED: [[SimpleTest]]: [MySQL] 46,247 pass(es). View
#5 interdiff.txt488 bytesCameron Tod
#3 1824712-open_id-convert_xri_proxy_resolver-3.patch2.1 KBCameron Tod
PASSED: [[SimpleTest]]: [MySQL] 46,242 pass(es). View
#3 interdiff.txt1.24 KBCameron Tod
#1 1824712-open_id-convert_xri_proxy_resolver.patch2.14 KBCameron Tod
PASSED: [[SimpleTest]]: [MySQL] 46,243 pass(es). View

Comments

Cameron Tod’s picture

Status:Active» Needs review
FileSize
2.14 KB
PASSED: [[SimpleTest]]: [MySQL] 46,243 pass(es). View

And here is a patch. Tests are passing locally.

alexpott’s picture

Status:Needs review» Needs work
+++ b/core/modules/openid/lib/Drupal/openid/Tests/OpenIDFunctionalTest.phpundefined
@@ -88,7 +88,9 @@ function testDiscovery() {
+    $config = config('openid.settings');
+    $config->set('xri_proxy_resolver', url('openid-test/yadis/xrds/xri', array('absolute' => TRUE)) . '/');
+    $config->save();

This could be written like this...

config('openid.settings')
  ->set('xri_proxy_resolver', url('openid-test/yadis/xrds/xri', array('absolute' => TRUE)) . '/')
  ->save();
Cameron Tod’s picture

Status:Needs work» Needs review
FileSize
1.24 KB
2.1 KB
PASSED: [[SimpleTest]]: [MySQL] 46,242 pass(es). View

Standards cleanup from #2.

alexpott’s picture

Status:Needs review» Needs work

Needs an hook_update_N function to migrate the variable from a Drupal 7 site.

Cameron Tod’s picture

Status:Needs work» Needs review
FileSize
488 bytes
2.66 KB
PASSED: [[SimpleTest]]: [MySQL] 46,247 pass(es). View

Added upgrade path.

Cameron Tod’s picture

FileSize
184 bytes
2.66 KB
PASSED: [[SimpleTest]]: [MySQL] 46,247 pass(es). View

Removed extra trailing carriage return.

alexpott’s picture

Status:Needs review» Reviewed & tested by the community
Issue tags:+Configuration system

Works as expected. Thanks for the work.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.