Comments

ParisLiakos’s picture

Status:Active» Needs review
StatusFileSize
new1.01 KB

patch

RobW’s picture

Status:Needs review» Fixed
RobW’s picture

Priority:Critical» Normal
Status:Fixed» Postponed

After conversation on IRC, rolled this back until Media 1.x is deprecated.

clemens.tolboom’s picture

Category:task» bug
Status:Postponed» Needs review
StatusFileSize
new1.66 KB

We are using media-7.x-2.x-dev which has

<?php
function media_access($op, $account = NULL) {
  return
user_access('administer files', $account);
}
?>

so this fails completely for regular users.

Why not try to use both?

clemens.tolboom’s picture

Issue summary:View changes

add link to file_entity issue

Devin Carlson’s picture

Issue summary:View changes
Related issues:+#2153459: Remove media_access()
StatusFileSize
new2.12 KB

A patch to add a wrapper functions which uses file_entity_access() or media_access() as appropriate.

gmclelland’s picture

@Devin Carlson - your patch worked for me. I just upgraded my site to latest media and file entity modules and I was getting a fatal error about this when loading the media browser. After the patch the error is gone.

Not sure if you want me set this to RBTC?

kaidjohnson’s picture

The patch in #5 works for us. I'm hesitant to mark this RTBC with the use of both media_access and file_entity_access.

Media and File Entity are pretty nicely versioned together. Media 2.x required File Entity 2.x and if using the -dev release of one, you should be using the -dev release of the other. Is the Media YouTube versioning system following this pattern as well? If so, we should be able to safely use only file_entity_access in the media_youtube 2.x-dev versions without the need to check against the legacy media_access function. If media_youtube 2.x-dev is expected to still be compatible with media 1.x, then yeah, I believe the patch in #5 should be marked RTBC.

ayalon’s picture

Patch worked for me too. Thanks!

deggertsen’s picture

Just tested the patch. It works!

SocialNicheGuru’s picture

patch worked for me too

helmo’s picture

Status:Needs review» Reviewed & tested by the community

Seems to have had review ;)

Devin Carlson’s picture

Status:Reviewed & tested by the community» Fixed

Thanks for the review!

Committed #5 to Media: YouTube 7.x-2.x.

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ChristianS17’s picture

Amazing Fix, thank you ever so much

darksnow’s picture

Great fix, thanks.

I've just updated media and this module has broken. I'll apply the fix in the patch above but when can I expect a new 7.2 release? There are a lot of people who can't or won't patch their code so a quick drush up to fix this issue would be appreciated and timely since it's been about a year ;)

Cheers.

web226’s picture

Thanks, patch in #5 worked for me

petednz’s picture

web226 - patch in #5 works for you against which version of Media?

joachim’s picture

Priority:Normal» Critical
Status:Closed (fixed)» Active

This isn't fixed completely until there's a new release been made. The current 7.x-2.0-rc4 is unusable without this fix. So at the very least, we need an rc5 release rolling.

rcodina’s picture

Using latest release of this module (7.x-2.0-rc4+18-dev) solved the problem for me too.

joachim’s picture

That is only a snapshot release, not an official release.

Devin Carlson’s picture

Priority:Critical» Normal
Status:Active» Closed (fixed)

This has already been committed to Media: YouTube 7.x-2.x.

I'm in the process of rolling a new release but I'd suggest filing a new issue RE: tagging a new stable release in the future for better visibility.

brunodbo’s picture

grinxols’s picture

StatusFileSize
new19.42 KB

I check "Web" instead of "Youtube" as the Brower Plugin in the file field configuration, and it works for me.

enblanch’s picture

Thanks grinxols i works #23 thank you ever so much!!!