Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
use file_entity_access instead.
see #1227706: Add a file entity access API
Comment | File | Size | Author |
---|---|---|---|
#23 | Screen Shot 2015-02-03 at 14.30.51.png | 19.42 KB | grinxols |
#5 | provide-access-wrapper-1823376-6.patch | 2.12 KB | Devin Carlson |
#4 | media-youtube-access-1823376-4.patch | 1.66 KB | clemens.tolboom |
#1 | 1823376_media-youtube-use-file-entity-access-api_1.patch | 1.01 KB | ParisLiakos |
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedpatch
Comment #2
RobW CreditAttribution: RobW commentedDone and done: http://drupalcode.org/project/media_youtube.git/commit/b5a46ca
Comment #3
RobW CreditAttribution: RobW commentedAfter conversation on IRC, rolled this back until Media 1.x is deprecated.
Comment #4
clemens.tolboomWe are using media-7.x-2.x-dev which has
so this fails completely for regular users.
Why not try to use both?
Comment #4.0
clemens.tolboomadd link to file_entity issue
Comment #5
Devin Carlson CreditAttribution: Devin Carlson commentedA patch to add a wrapper functions which uses
file_entity_access()
ormedia_access()
as appropriate.Comment #6
gmclelland CreditAttribution: gmclelland commented@Devin Carlson - your patch worked for me. I just upgraded my site to latest media and file entity modules and I was getting a fatal error about this when loading the media browser. After the patch the error is gone.
Not sure if you want me set this to RBTC?
Comment #7
kaidjohnson CreditAttribution: kaidjohnson commentedThe patch in #5 works for us. I'm hesitant to mark this RTBC with the use of both media_access and file_entity_access.
Media and File Entity are pretty nicely versioned together. Media 2.x required File Entity 2.x and if using the -dev release of one, you should be using the -dev release of the other. Is the Media YouTube versioning system following this pattern as well? If so, we should be able to safely use only file_entity_access in the media_youtube 2.x-dev versions without the need to check against the legacy media_access function. If media_youtube 2.x-dev is expected to still be compatible with media 1.x, then yeah, I believe the patch in #5 should be marked RTBC.
Comment #8
ayalon CreditAttribution: ayalon commentedPatch worked for me too. Thanks!
Comment #9
deggertsen CreditAttribution: deggertsen commentedJust tested the patch. It works!
Comment #10
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedpatch worked for me too
Comment #11
helmo CreditAttribution: helmo commentedSeems to have had review ;)
Comment #12
Devin Carlson CreditAttribution: Devin Carlson commentedThanks for the review!
Committed #5 to Media: YouTube 7.x-2.x.
Comment #14
ChristianSanders CreditAttribution: ChristianSanders commentedAmazing Fix, thank you ever so much
Comment #15
darksnow CreditAttribution: darksnow commentedGreat fix, thanks.
I've just updated media and this module has broken. I'll apply the fix in the patch above but when can I expect a new 7.2 release? There are a lot of people who can't or won't patch their code so a quick drush up to fix this issue would be appreciated and timely since it's been about a year ;)
Cheers.
Comment #16
web226 CreditAttribution: web226 commentedThanks, patch in #5 worked for me
Comment #17
petednz CreditAttribution: petednz commentedweb226 - patch in #5 works for you against which version of Media?
Comment #18
joachim CreditAttribution: joachim commentedThis isn't fixed completely until there's a new release been made. The current 7.x-2.0-rc4 is unusable without this fix. So at the very least, we need an rc5 release rolling.
Comment #19
rcodina CreditAttribution: rcodina commentedUsing latest release of this module (7.x-2.0-rc4+18-dev) solved the problem for me too.
Comment #20
joachim CreditAttribution: joachim commentedThat is only a snapshot release, not an official release.
Comment #21
Devin Carlson CreditAttribution: Devin Carlson commentedThis has already been committed to Media: YouTube 7.x-2.x.
I'm in the process of rolling a new release but I'd suggest filing a new issue RE: tagging a new stable release in the future for better visibility.
Comment #22
brunodboIssue created at #2404987: Roll new 2.0-rc5 release.
Comment #23
grinxols CreditAttribution: grinxols commentedI check "Web" instead of "Youtube" as the Brower Plugin in the file field configuration, and it works for me.
Comment #24
enblanch CreditAttribution: enblanch commentedThanks grinxols i works #23 thank you ever so much!!!
Comment #25
galayant CreditAttribution: galayant commentedHello,
Do you know if this patch ( provide-access-wrapper-1823376-6.patch) is included in the 2.0-rc5 stable version?
Thanks
Comment #26
weseze CreditAttribution: weseze commentedThis issue is fixed in rc5.