I have noticed this morning that hook_nodeapi is no longer called by $node as first argument as first setting, but only $type. I documented this in the handbook, 'cos I have thought this is well thought out decision which is executed through the core. But only node.module is updated, comment and upload is broken and every node module out there. I know we do not have backwards compatibility. I think it would be better to introduce a new hook for this. But, as we are in feature freeze, I doubt any of this shall happen. Instead, for now let's change the behaviour back.

CommentFileSizeAuthor
#3 nodeapi_settings_2.patch2.92 KBasimmonds
nodeapi_settings.patch2.49 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx’s picture

Resetting to patch, as Dries just commented this as 'slightly better'.

asimmonds’s picture

FileSize
2.92 KB

Slightly updated patch that now does both $node->type references in the form_checkboxes call, and the change to the phpDOC.

asimmonds’s picture

Err, somethings funny with the issue version field, changing back to cvs.

Dries’s picture

Committed to HEAD.

Anonymous’s picture