Drupal.flexsliderViewsSlideshow.active["#flexslider_views_slideshow_main_" + options.slideshowID].resume is not a function [#1821176]

I have a Views slideshow using flexslider, after clicking the 'pause' control and then clicking again to resume, I get a javascript error in the Firebug console:
Drupal.flexsliderViewsSlideshow.active["#flexslider_views_slideshow_main_" + options.slideshowID].resume is not a function

The source of the error is line 84 of flexslider_views_slideshow/js/flexslider_views_slideshow.js:

// Play mapping from Views Slideshow to FlexSlider
  Drupal.flexsliderViewsSlideshow.play = function (options) {
    Drupal.flexsliderViewsSlideshow.active['#flexslider_views_slideshow_main_' + options.slideshowID].resume();
    Drupal.flexsliderViewsSlideshow.active['#flexslider_views_slideshow_main_' + options.slideshowID].manualPause = false;
  }

Flexslider documents a resume() method ( http://www.woothemes.com/flexslider/ ) but after looking through the Flexslider source code, I can find no mention of it.

Seems like the heart of the issue is the missing method in the Flexslider plugin, but in the meantime this could be at least significantly improved by changing resume() to play().

I could write a patch if needed.

Comment	File	Size	Author
#5	flexslider-resumeplay-1821176-5.patch	3.18 KB	alexkb
#4	flexslider-resumeplay-1821176.patch	1.5 KB	alexkb

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

minorOffense CreditAttribution: minorOffense commented 25 October 2012 at 18:05

Are you using the 1.8 version of the Flexslider library? The docs online are for the 2.x version (as far as I can tell). This should work so long as you have 1.8 installed.

Comment #2

minorOffense CreditAttribution: minorOffense commented 25 October 2012 at 18:05

Status:

Active

» Postponed (maintainer needs more info)

Comment #3

justindodge CreditAttribution: justindodge commented 25 October 2012 at 18:51

Status:

Postponed (maintainer needs more info)

» Closed (works as designed)

Thanks for the reply - sure enough, 1.8 version of the Flexslider lib does not cause this error.

I had just downloaded the most recent version of the lib available via their main download link on the homepage (2.1). I wasn't able to find any documentation for the Drupal module that recommends using the older version of Flexslider though, unless I am just totally blowing over it (very possible) I might suggest making it a little more explicit since one needs to dig into the github project page in order to obtain 1.8.

Thanks for your help!

Comment #4

alexkb CreditAttribution: alexkb commented 27 June 2013 at 07:38

Status:

Closed (works as designed)

» Needs review

File	Size
flexslider-resumeplay-1821176.patch	1.5 KB

Attached is a patch for the 1.x branch of this module that will use resume() (present in v1.8 library of Flexslider) if it's available, or if it's not, then it will use play() (present in v2.x library of Flexslider).

Comment #5

alexkb CreditAttribution: alexkb commented 10 July 2013 at 06:53

File	Size
flexslider-resumeplay-1821176-5.patch	3.18 KB

When enabling the next/previous buttons, we were also seeing "Uncaught TypeError: Cannot read property 'pauseOnAction' of undefined". I've attached a fix for this which includes the changes from my previous patch on the 1.x branch.