I think we can make this function slightly cleaner. We also don't need is_subclass_of check anymore.

I know this can wait until after Dec 1st, but I had some time to kill on the train and spotted this in passing.

CommentFileSizeAuthor
core-views-tidy-hook_page_alter.patch791 bytesdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

We are 100% sure this is tested somewhere?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Well, we don't test legacy code.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

true ;)

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Issue tags: +VDC

tagging

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.