Problem/Motivation

Several drupal theme functions result in exactly the same markup structures. 

<div class="{{ attributes.class }}" {{ attributes }}>{{ children }}</div>

As we convert to twig we should take the opportunity to consolidate what can be consolidated, and add theme_hook suggestions where particular instances of these structures may need to be overridden independently.

Proposed resolution

Implement theme('container') wherever possible, and add theme_hook_suggestions for all variations, including:

Remaining tasks

#2041825: Remove theme_radios() and call theme('container') instead
#2041845: Remove theme_checkboxes() and call theme('container') instead

Related tasks

#939462: Specific preprocess functions for theme hook suggestions are not invoked
#1751194: Introduce hook_theme_suggestions[_HOOK]() and hook_theme_suggestions[_HOOK]_alter()
#1804614: [meta] Consolidate theme functions and properly use theme suggestions in core
#1285506: Radios select in form dont have unique wrapper class
#1898480: [meta] form.inc - Convert theme_ functions to Twig

User interface changes

None.

API changes

TBD

Comments

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Title: radios.html.twig and checkboxes.html.twig should be consolidated » Consolidate all form element theme functions that use containers
Component: routing system » theme system

Updating title.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue summary: View changes

added info about container.html.twig

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Title: Consolidate all form element theme functions that use containers » [meta] Consolidate all form element theme functions that use containers

updating again :/

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Title: [meta] Consolidate all form element theme functions that use containers » [meta] Consolidate all form element container templates, and add theme_hook_suggestions
Assigned: Unassigned » jenlampton

updating title.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue summary: View changes

add links to api.drupal.org

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue summary: View changes

issue summary

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue summary: View changes

clean

c4rl’s picture

c4rl CreditAttribution: c4rl commented

Related #1848116: Revise usage of {% include %}

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue tags: +Template consolidation

tagging

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue summary: View changes

related

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue summary: View changes

add element

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue summary: View changes

sub issues

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Issue summary: View changes

reorg

mitokens’s picture

mitokens CreditAttribution: mitokens as a volunteer commented
Parent issue: » #1804614: [meta] Consolidate theme functions and properly use theme suggestions in core

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin for ImageX commented
Issue summary: View changes

#1114398: Form element & Form element label theming is broken was fixed in D8. Removing it from the issue summary.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Version: 8.6.x-dev » 8.9.x-dev

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.