Mobile Tools currently implements its own hooks to provide default device groups and detection. This code should be offloaded to a submodule for a number of reasons:

  • Easier readability of mobile_tools.module
  • Removes special casing of Mobile Tools' implementation of its own hooks (if detection = "mobile_tools" do something special)
  • Reduces the amount of code that has to load on every request
  • Gets around the current name collision problem of having the hook and implementation having the same name
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Devin Carlson’s picture

Status: Active » Needs review
FileSize
26.78 KB

A patch to migrate device detection from Mobile Tools to a sub module called "Mobile Tools Detection".

Devin Carlson’s picture

Status: Needs review » Fixed

Committed to 6.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.