Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
The Twitter Sign-In module should use url()
to print the correct link to user/<uid>/edit
.
Comment | File | Size | Author |
---|---|---|---|
#3 | twitter_signin-1814618-3-use_l.patch | 845 bytes | xurizaemon |
#1 | 1814618-use-url.patch | 640 bytes | fizk |
Comments
Comment #1
fizk CreditAttribution: fizk commentedHere's a patch.
Comment #2
fizk CreditAttribution: fizk commentedComment #3
xurizaemonTrivial but probably should use l() instead?
I'm not particularly keen on printing the generated password to the screen as we do in twitter_signin_oauth_callback_submit(), but that's another issue: #1816278: Registering account via Twitter Signon should not display the password
Comment #4
xurizaemonOh rubbish, I unintentionally rolled this into a trivial docfix. Apologies. Issue fixed now.
http://drupalcode.org/project/twitter.git/commit/75fb334
Comment #6
Elijah LynnComment #7
anacolautti CreditAttribution: anacolautti commentedHello there! The patch from #2 makes the string untranslatable. According to the l() documentation, the correct way to implement it was like the patch in #1.
Can we please roll back to #1? Do you need a new patch? We can definitively provide you with one. Thanks
Comment #8
xurizaemonSince this was committed two years ago to 7.x-3.x and we're currently developing for 7.x-6.x, please report a new issue and supply a patch there. Do reference the previous commit & issue in that one. Thanks!