This is a sub-issue of #1775842: [meta] Convert all variables to state and/or config systems. This issue will convert variable 'node_access_test_private' to use the state() system.

This variable is used in four node access tests. For namespace purposes, renaming to 'node_access_test.private'.

#3 1814402-teardown-removed.patch3.53 KBmoe4715
PASSED: [[SimpleTest]]: [MySQL] 47,583 pass(es).
[ View ]
#1 1814402-1-convert-natp-variable.patch4.54 KBLars Toomre
PASSED: [[SimpleTest]]: [MySQL] 42,570 pass(es).
[ View ]


Lars Toomre’s picture

Status:Active» Needs review
new4.54 KB
PASSED: [[SimpleTest]]: [MySQL] 42,570 pass(es).
[ View ]

Here is a locally untested patch that converts all occurrences of 'node_access_test_private' variable in core.

Berdir’s picture

Status:Needs review» Needs work

There's no need for tearDown(), state is thrown away after the test execution just like everything else.

moe4715’s picture

Status:Needs work» Needs review
new3.53 KB
PASSED: [[SimpleTest]]: [MySQL] 47,583 pass(es).
[ View ]

All tearDown() functions are now deleted.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community


catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.