This is a sub-issue of #1775842: [meta] Convert all variables to state and/or config systems. This issue will convert variable 'node_access_test_private' to use the state() system.

This variable is used in four node access tests. For namespace purposes, renaming to 'node_access_test.private'.

CommentFileSizeAuthor
#3 1814402-teardown-removed.patch3.53 KBmoe4715
#1 1814402-1-convert-natp-variable.patch4.54 KBLars Toomre
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Status: Active » Needs review
FileSize
1814402-1-convert-natp-variable.patch4.54 KB

Here is a locally untested patch that converts all occurrences of 'node_access_test_private' variable in core.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Needs work

There's no need for tearDown(), state is thrown away after the test execution just like everything else.

moe4715’s picture

moe4715 CreditAttribution: moe4715 commented
Status: Needs work » Needs review
FileSize
1814402-teardown-removed.patch3.53 KB

All tearDown() functions are now deleted.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Thnx!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.