Mobile support [#1814306]

Hi guys, absolutely love the module. It's so simple and effective. I was trying to post a video from my Iphone and obviosuly youtube and I beleive vimeo gives a mobile url which doesn;t seem to work. From youtube it looks something like this http://m.youtube.com/index?desktop_uri=%2F&gl=GB#/watch?feature=mhee&v=e...

and vimeo like this http://vimeo.com/m/51430433

Any chance for maybe supporting the mobile url?

Comment	File	Size	Author
#8	video-embed-field_youtube-mobile-link_1814306_8.patch	402 bytes	boshtian
#8
#2	video-embed-field_youtube-mobile-link-1814306-2.patch	1.77 KB	wbobeirne
#2
#1	video-embed-field_youtube-mobile-link-1814306-1.patch	406 bytes	wbobeirne
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

wbobeirne CreditAttribution: wbobeirne commented 17 October 2012 at 15:30

Status:

Active

» Needs review

File	Size
video-embed-field_youtube-mobile-link-1814306-1.patch	406 bytes

The Vimeo video worked for me out of the box. Is it not working for you?

As for youtube, it was an incredibly simple fix. Simply adding m.youtube.com to the list of domains worked for me without needing to change anything else. I'm not sure how complicated the URLs can get though. Attached is that patch.

EDIT: Please disregard this post. I spoke much too quickly, and was still looking at cached data. Working on a proper fix now.

Comment #2

wbobeirne CreditAttribution: wbobeirne commented 17 October 2012 at 15:36

File	Size
video-embed-field_youtube-mobile-link-1814306-2.patch	1.77 KB

Apologies for the previous post.

Attached this time is a more thorough fix. This will allow subdomains of any handler's URLs to work.

Comment #3

kappaluppa CreditAttribution: kappaluppa commented 21 March 2014 at 19:27

Issue summary:

View changes

I've added this patch frm #2 to 7.x-2.0-beta7 and it fixes the mobile uploads problem. I have to try with other variations of the youtube urls. Can this get committed? I recently updated my module on my site and have to patch again.

Thanks.

Comment #4

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 20 April 2014 at 10:01

Hello

I'd prefer to include the patch provided in #1, given that the use of #2 will allow to include fake subdomains which could broke the site, for instance "foo.youtube.com"

Why do you say that #1 does not work? I made some brief tests and looks like it works.

Thank you for your effort @wbobeirne

Comment #5

mubiesam CreditAttribution: mubiesam commented 2 October 2014 at 15:23

does the patch add into beta8 already...any confirmation of which patch to be used...

Thanks,

Comment #6

mubiesam CreditAttribution: mubiesam commented 4 October 2014 at 02:23

applied the patch #1, but it will not play the video with one tap on mobile as normally it should, only by long press on screen (as right click mouse key), and tap again after menu popup...

Any idea what maybe the cause...

Thanks,

Comment #7

boshtian CreditAttribution: boshtian commented 31 May 2016 at 11:37

Version:	7.x-2.x-dev	» 7.x-2.0-beta11
Status:	Needs review	» Reviewed & tested by the community

I agree with plopesc, I also think that solution in #1 is better and I confirm it is working.

How come this didn't get to the release yet? We have beta-11 now and it's still not in there. I see this as a small fix and could be easily added.

Comment #8

boshtian CreditAttribution: boshtian commented 31 May 2016 at 11:52

Status:

Reviewed & tested by the community

» Needs review

File	Size
video-embed-field_youtube-mobile-link_1814306_8.patch	402 bytes

I created a new patch, because the one above wasn't working against the latest version. So if anyone is using beta-11, you can use this one.

Comment #9

tyler.frankenstein CreditAttribution: tyler.frankenstein commented 7 October 2016 at 00:55

Component:	Miscellaneous	» Code
Status:	Needs review	» Reviewed & tested by the community

#8 works for me, don't forget a cache clear all to pick up the new changes.

P.S. I overlooked the issue's mention of mobile support for Vimeo. The patch is RTBC only for mobile YouTube support. Please feel free to set back to Needs work if need be.