While doing a review of the Tracker module from a documentation perspective, it appears that class member variables access_user and no_access_user are not used. These at minimum should be removed and a thorough coding review of the two tests performed.

Files: 
CommentFileSizeAuthor
#7 tests-cleaned-up-1813318-7.patch1.97 KBPalashvijay4O
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,090 pass(es), 2 fail(s), and 0 exception(s). View
#3 tracker_cleanup-1813318-3.patch1.15 KBkfritsche
FAILED: [[SimpleTest]]: [MySQL] 47,584 pass(es), 1 fail(s), and 0 exception(s). View

Comments

Lars Toomre’s picture

The TrackerTest.php class uses both the Tracker and Comment modules in its tests. In the setUp() function for this class, there is a variable_set('commnet_preview_page', 0). Doing a grep through core code, I find no other reference to this particular variable.

I suspect that at some point the variable was converted to config/state sub-systems and this was overlooked. Anyone have an idea of what this should be converted to?

penyaskito’s picture

Issue tags: +Novice, +Configuration system

Tagging.

kfritsche’s picture

Status: Active » Needs review
FileSize
1.15 KB
FAILED: [[SimpleTest]]: [MySQL] 47,584 pass(es), 1 fail(s), and 0 exception(s). View

Reviewed both tests too. Others from your comment, it seems fine to me.
Deleted both unused member variables.

The variable 'comment_preview_'.$type (in this case 'page') is still used. Therefore only added the TODO right now.
I'm going to search now for the comment issue to remove the variables in the comments module and will come back here later again, if this is finished.

Status: Needs review » Needs work

The last submitted patch, tracker_cleanup-1813318-3.patch, failed testing.

kfritsche’s picture

Status: Needs work » Postponed

#1776076: Convert comment module configuration to CMI is the CMI issue for the comment.module.

Setting this to postponed, till this is fixed.

mgifford’s picture

it is.

Palashvijay4O’s picture

Assigned: Unassigned » Palashvijay4O
Status: Needs work » Needs review
FileSize
1.97 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,090 pass(es), 2 fail(s), and 0 exception(s). View

Submitting a patch.

Status: Needs review » Needs work

The last submitted patch, 7: tests-cleaned-up-1813318-7.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: tests-cleaned-up-1813318-7.patch, failed testing.

rpayanm’s picture

Variables access_user and no_access_user in class core/modules/tracker/src/Tests/TrackerNodeAccessTest.php not longer exist.

rpayanm’s picture

Assigned: Palashvijay4O » Unassigned
Status: Needs work » Closed (cannot reproduce)