Remove dependency on the standard profile from LocaleContentTest

Excellent patch.

+++ b/core/modules/locale/lib/Drupal/locale/Tests/LocaleContentTest.phpundefined
@@ -198,12 +201,12 @@ function testContentTypeDirLang() {
-  protected function createNodeArticle($langcode) {
-    $this->drupalGet('node/add/article');
+  protected function createNode($langcode, $type) {
+    $this->drupalGet("node/add/$type");
     $node_title = $this->randomName();
     $node_body =  $this->randomName();
     $edit = array(
-      'type' => 'article',
+      'type' => $type,
       'title' => $node_title,
       'body' => array($langcode => array(array('value' => $node_body))),
       'langcode' => $langcode,

Maybe we can remove this helper entirely, and instead add an optional $langcode parameter to drupalCreateNode()? Edit: Or just make drupalCreateNode() use the langcode provided when generating a random body.

Discussed with @tim.plunkett in IRC; I'll add something along the lines of #3.

Attached:

• Updates WebTestBase::drupalCreateNode() to automatically use the provided langcode when generating a body. (This can of course be overridden.)
• Adds a proper docblock and constants to WebTestBase::drupalCreateNode() while I'm at it.
• Updates LocaleContentTest to get rid of the superfluous helper and just use drupalCreateNode() directly.
• Removes t() from the assertions in the updated methods since this is going to collide with #1797364: Remove t() from assertion messages in tests for the locale module anyway.

Didn't test it locally; I don't yet guarantee there are no typos. ;)

+++ b/core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.phpundefined
@@ -186,27 +186,58 @@ function drupalGetNodeByTitle($title, $reset = FALSE) {
+    // If a langcode is provided in $settings, use it as the default language
+    // for generating a random body; otherwise, use LANGUAGE_NOT_SPECIFIED.
+    $langcode = (!empty($settings['langcode']) ? $settings['langcode'] : LANGUAGE_NOT_SPECIFIED;
...
+      'body'      => array($langcode => array(array())),
...
-      'langcode'  => LANGUAGE_NOT_SPECIFIED,
+      'langcode'  => $langcode,

Oh. Looking more closely, these lines might not actually be correct. Down below it does this:

  // Merge body field value and format separately.
  $body = array(
    'value' => $this->randomName(32), 
    'format' => filter_default_format(),
  );
  $settings['body'][$settings['langcode']][0] += $body;

And indeed there was a typo:

Parse error: syntax error, unexpected ';' in ./core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.php on line 226

So, two versions; one includes the change to drupalCreateNode(); the other does not. Let's see if there's any difference as far as tests are concerned.

So that answers that question.

There we go.

Filed #1812732: Use constants instead of integers in drupalCreateNode() and improve its documentation for the earlier cleanups and to better document the behavior with the langcodes.

Er. Where did you go, patch? Re-uploading...

That looks good.

Yay, faster and more generally useful tests!

Boo, doesn't apply. ;(

Just a rebase.

Yay! Committed and pushed to 8.x.