I ran into more weird behavior where I was using aes and encrypt seemed to be returning an empty string. Making it base64 made everything great. So, I think we should just default to that.

Also, we're not currently storing the $options with the encrypted data, but should probably do that.

CommentFileSizeAuthor
#4 1811422_log_options_4.patch1.14 KBgreggles
#2 1811422_log_options.patch480 bytesgreggles
default_base64_aes.patch614 bytesgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Title: default to base64 whenever aes is being used » log the options

Actually, the second change won't catch the first change and i decided it was more important to record options than have this default to on. We should just document the base64 usage more.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
FileSize
1811422_log_options.patch480 bytes

Status: Needs review » Needs work

The last submitted patch, 1811422_log_options.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs work » Needs review
FileSize
1811422_log_options_4.patch1.14 KB

That test just counts the items in the array, so it makes sense that by adding one more item it now fails. Updated and passes locally now.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs review » Fixed

This has been working well for me for a while. Committed - http://drupalcode.org/project/encrypt.git/commit/refs/heads/7.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.