Presupposes accepting patch for adopting YAML info-file format:
#1793074-80: Convert .info files to YAML
The proposal is to use a static format filename for the new info-file, rather than the historic variable format that varied with the module name (ie. modulename.info
)
Related conversation from linked thread:
@sun originally raised a concern in #75 about the variable format's false positives when drupal was simply looking to parse any YAML files.
@cweagans reiterated the valid concern in #83, that static format would be cumbersome when multiple info-files are open in the editor.
As @sun mentioned in #84: static format might act as a trivial way to enforce one-module-per-directory.
Reference issue: #1299424: Allow one module per directory and move system tests to core/modules/system
@tstoeckler had this to say in #89:
I also agree with #84, but until themes are actually full extensions (#1067408: Themes need an installation status), and we actually have the concept of extensions in core (#1331486: Move module_invoke_*() and friends to an Extensions class), I think it would make sense to go with module.yaml for now, instead of extension.yaml. Since the latter would also require parsing each file to know it is a module (and introducing a type key for that purpose), I would consider that feature-creep, even it is the intended goal in the end.
Comments
Comment #1
patcon CreditAttribution: patcon commentedClearer topic.
Comment #2
cweagansI've already expressed my distaste at this approach in the other issue, so I'll just leave it at this:
-1
Comment #3
PanchoI agree that this doesn't seem to be a good idea.
If #1398772: Replace .info.yml with composer.json for extensions makes a static filename unavoidable and still is the right way to go, then be it. But otherwise, duplicate filenames really aren't nice in editor tabs. I know that such are common in other projects, but that's nor reason to unnecessarily make our codebase harder to maintain.
Actually I don't even see a compelling reason to do it:
The current naming proposal in #1793074: Convert .info files to YAML avoids false-positives, so this argument is ruled out.
And if we feel enforcing the one-module-per-directory rule (#1299424: Allow one module per directory and move system tests to core/modules/system) is necessary, then this should be the subject of this issue and we need to evaluate the best way to accomplish it.
Comment #4
sunPostponing on #1793074: Convert .info files to YAML
Comment #5
mgiffordComment #6
cweagansComment #7
catchWe could support this for forward compatibility in a late 8.x minor release.