Currently the method assertNodeAccess() is a method of NodeAccessLanguageTest.php. This is a generalized test that would be helpful to other test classes both in core and contrib. Hence, let's move it to WebTestBase.php where it would be available to all tests that extend that class.

CommentFileSizeAuthor
#1 1805624-1-move-assert.patch2.89 KBLars Toomre
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
FileSize
1805624-1-move-assert.patch2.89 KB

Here is a untested patch for this issue. Reviewers will note the addition of a docblock plus the renaming of $msg to $message and $ops to $operations in order to conform with convention that variables should not be abbreviations.

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Status: Active » Needs review

Grr.. Really need to remember to set right status!

Status: Needs review » Needs work

The last submitted patch, 1805624-1-move-assert.patch, failed testing.

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Status: Needs work » Needs review

Looks like method assertNodeAccess() can be removed from NodeAccessTest.php and use the version that now is being moved to WebTestBase.php.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Component: node.module » node system
Issue summary: View changes

(Merging "node system" and "node.module" components for 8.x; disregard.)

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Needs review » Closed (works as designed)

assertNodeAccess() is now part of NodeTestBase, which makes sense since WebTestBase cannot necessarily assume the node module is enabled.