I would have thought access to /admin/config/workbench should use the 'administer workbench' permission instead of 'access workbench'. The 'administer workbench' permission isn't actually used anywhere in workbench (or any of the workbench add on modules that we have enabled). As it is now, content editors (or anyone with the ability to access the workbench) can also acess the admin page at /admin/config/workbench - which just shows "You do not have any administrative items.", which is confusing.

Files: 
CommentFileSizeAuthor
#6 workbanch-permissions.png42.53 KBsardbaba
#1 1803198-workbench-admin-permissions.patch523 bytesmrfelton
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Comments

mrfelton’s picture

Status:Active» Needs review
StatusFileSize
new523 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
Devin Carlson’s picture

Status:Needs review» Reviewed & tested by the community

The patch applied cleanly and fixed the configuration section using the wrong permission.

agentrickard’s picture

Status:Reviewed & tested by the community» Fixed

Committed.

   6857511..f40e723  7.x-1.x -> 7.x-1.x
mrfelton’s picture

ps, thanks for the (lack of) patch attribution! ;)

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sardbaba’s picture

Version:7.x-1.x-dev» 7.x-1.2
Status:Closed (fixed)» Needs work
StatusFileSize
new42.53 KB

In workbench.module (7.x-1.2 version) I see this (as #1):

  $items['admin/config/workbench'] = array(
    'title' => 'Workbench',
    'description' => 'Workbench',
    'page callback' => 'system_admin_menu_block_page',
    'access arguments' => array('administer workbench'),
[......]

but is not working for me, as administrator.
I dunno why this isn't working. Any idea?

agentrickard’s picture

Category:bug» support
Status:Needs work» Active

Have you cleared the cache / run update.php?

By "administrator" do you mean user 1?

sardbaba’s picture

Yep, both cache cleared and I ran update.php.
And, yes, by "administrator" I mean user 1, of course :)

agentrickard’s picture

Do you have any of the submodules enabled (Workbench Moderation, Workbench Access)? If not, this item won't appear because Workbench itself has no configuration.

sardbaba’s picture

Status:Active» Fixed

Oh sh**! Sorry :)

Anyway, there is a usability problem in this: if you give the ability to access to a configuration page, but the configuration page doesn't have any configurations is better to follow one of the next options:
1) the configuration page has no sense to exists;
2) if you need to have the configuration page, is better display a message like "There aren't configurations at the moment" instead of an access error message.

agentrickard’s picture

Blame core's handling of configuration blocks. This works as designed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.