Backstory

Patches for the Media module are currently being postponed because run-tests.sh reports that no tests are found. This happens because Media specifies that the File entity module must be available in order to run tests 'dependencies' => array('file_entity'), but the testbot is not downloading File entity.

File entity is not being downloaded because Media uses a versioned dependency on File entity dependencies[] = file_entity (>1.99) (thanks rfay for explaining how that works! #1734648: Media 2.x branch missing dependencies).

Issue

The versioned dependency was changed to an unversioned dependency (dependencies[] = file_entity) with #1749252: Add check for File entity 2.x to installation requirements and a couple of days have passed but the Media 7.x-2.x branch tests haven't updated http://qa.drupal.org/pifr/test/158824.

Can the dependencies for Media 7.x-2.x be rebuilt? The tests are now passing on my local machine.

Thanks!

Comments

rfay’s picture

Sorry, Project Dependency does not support versioned dependencies at all. #1351744: Respect versioned dependencies and soft dependencies

Are you aware that you can force a test at http://drupal.org/project/media/testing-status? Probably in this case you should "Remove test" and then test.

Devin Carlson’s picture

Yes, the dependency was changed from dependencies[] = file_entity (>1.99) to dependencies[] = file_entity to accommodate the dependency issue.

It sounds like forcing a test is the way to go (I was unaware that you could do that)! However, I'm getting "Access denied" when going to http://drupal.org/project/media/testing-status. Are there any requirements for forcing a test (I'm not a maintainer of the Media module)?

jthorson’s picture

Status: Active » Fixed

Requeued, and the test is now passing.

rfay’s picture

Wow, I thought *everybody* had access to the automated testing tab. Has that changed on purpose, @jthorson ?

jthorson’s picture

It should be visible if:

  • Is a project
  • Has a git repository
  • User has 'pift access project testing' permission (all authenticated)
  • Project has releases

Based on this, I can't explain the access denied result for Media ...

ParisLiakos’s picture

Status: Fixed » Active

Hmm can we rebuild the dependencies? media 2.x testing still checkouts file_entity unstable5..but file_entity already has not just unstable6 but also a fresh dev version
see here http://qa.drupal.org/pifr/test/158824

[3] => Array
                        (
                            [repository] => Array
                                (
                                    [type] => git
                                    [url] => git://git.drupal.org/project/file_entity.git
                                )

                            [vcs_identifier] => 7.x-2.0-unstable5
                        )

thanks

ps i already tried removing and re-adding test for both media and file_entity, doesnt do the trick:(

ParisLiakos’s picture

Status: Active » Fixed

ok got it..i think thats because tests fail on unstable6 -.-

rfay’s picture

No, it did need rebuilding - was stuck depending on unstable5.

Note that a dev will only show up as a dependency if there is no stable version. It will always try to use the "recommended version", which is always a stable release unless there is no stable release.

However, I rebuilt, and now it seems you removed the file_entity dependency?

+ /home/rfay/bin/drush -r /var/www/drupal.org/htdocs pdsd media 7.x-2.x-dev
Array
(
    [1738460] => Array
        (
            [uri] => ctools
            [version] => 7.x-1.2
            [tag] => 7.x-1.2
        )

    [1751522] => Array
        (
            [uri] => views
            [version] => 7.x-3.5
            [tag] => 7.x-3.5
        )

)
ParisLiakos’s picture

uh oh..no dependency is still there

dependencies[] = file_entity
dependencies[] = image
dependencies[] = views

http://drupalcode.org/project/media.git/blob/c425355:/media.info

hmm thats weird :/

rfay’s picture

Status: Fixed » Active

Weird. I confirm that 7.x-2.x has file_entity as a dependency.

But I even did a sourcecode delete and built this from scratch and see only the above deps from #8

So something is in fact wrong. I kind of wonder if there's a parsing problem with all those lines being there with no whitespace between them.

name = Media
description = Provides the core Media API
package = Media
core = 7.x
dependencies[] = file_entity
dependencies[] = image
dependencies[] = views
files[] = includes/MediaReadOnlyStreamWrapper.inc

It's a bit unusual, but it should parse correctly. I'd kind of appreciate if you'd add a blank line after core= and one before files= and see if it has any effect, before I get out the scalpel and download the whole d.o db and all that.

ParisLiakos’s picture

rfay’s picture

Shucks, no change.

It was a long shot and would have been a surprise, but it was cheap to check :-)

I'll see if I can take a look at this in the next few days. Unfortunately, it gets rather stale...

rfay’s picture

This is kind of a catch-22 that I don't know a way out of.

The "Recommended release" which contains file_entity *happens* to be Media 7.x-1.2. Obviously you've spun it off.

But since 7.x-1.2 is still "media", it's not external, so not considered an external dependency.

Possibly an unstable release of 7.x-2.x would fix this, but I'm not sure.

Related: #1798338: Privatemsg 6.x-2.x fails testing (double checkout?)

Probably our search algorithm needs to take into account the minor version of the branch. This is kind of the nether regions of dependency searching...

ParisLiakos’s picture

hmm yeah file_entity 1.x was included in media module..It is a separate project in 2.x now.
Thanks for your time rfray, i ll let you know what happens when a new unstable release is out

rfay’s picture

A new release of media won't help. I think this can only be solved by moving along #1351744: Respect versioned dependencies and soft dependencies

Devin Carlson’s picture

rfay, per your comment in #13, do you think making Media 7.x-2.x the recommended release would help the problem until #1351744: Respect versioned dependencies and soft dependencies is dealt with?

rfay’s picture

I'm pretty sure that making media 7.x-2.x the recommended release would solve the problem. But it would create new problems for every media 7.x-1.x user in the world who would see that as a need to upgrade to a new (compatibility problem?) version of media. If it *is* the recommended release, then you should change it.

rfay’s picture

Edit: It also might trigger a fatal bug where media 1.x was loaded in addition to 2.x in order to satisfy the dependency. That would not be a happy outcome.

ParisLiakos’s picture

Hmm seems the new file_entity unstable release fixed this
http://drupal.org/project/media/testing-status

rfay’s picture

Status: Active » Fixed

We now support versioned dependencies. http://qa.drupal.org/node/198

Thanks for letting us know.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated headers.