Pre-requisite:
User is on Create New Account page.

Steps:
1. Enter valus in Username field which is already registered.
2. enter email address
3. Click Finish button

Actual:
System displays validation message as "The name xyz is already taken"

Expected:
System should validation message as "The username xyz is already taken" i.e. 'name' text should be replaced with 'Username"

CommentFileSizeAuthor
#23 string_inconsistency-1802128-23.patch20.28 KBlegolasbo
#21 user-username_string_inconsistency-1802128-19.patch2.24 KBlegolasbo
#13 username-string-inconsistency-d8-1802128-13.patch93.14 KBlegolasbo
#8 1802128.8-username-string-inconsistency-d8.patch56.44 KBroam2345
#5 1802128.5-username-string-inconsistency-d8.patch54.76 KBroam2345
#1 1802128.2-username-string-inconsistency.patch1.81 KBroam2345

Comments

roam2345’s picture

roam2345 commented
Status: Active » Needs review
StatusFileSize
new 1802128.2-username-string-inconsistency.patch1.81 KB

here is a patch to fix the username inconsistency

Status: Needs review » Needs work

The last submitted patch, 1802128.2-username-string-inconsistency.patch, failed testing.

marcingy’s picture

marcingy commented
Version: 7.x-dev » 8.x-dev

Issue need to be fixed in d8 first note as this is a string change it might not be able to be backported to d7.

Anonymous’s picture

Anonymous (not verified) commented

Let's get technical linguistically and call it "User name" and "user name" throughout. It will lend itself better to translations.

roam2345’s picture

roam2345 commented
StatusFileSize
new 1802128.5-username-string-inconsistency-d8.patch54.76 KB

Here is a patch against D8. (first attempt lets see how many tests i kill)

roam2345’s picture

roam2345 commented
Status: Needs work » Needs review

change status.

Status: Needs review » Needs work

The last submitted patch, 1802128.5-username-string-inconsistency-d8.patch, failed testing.

roam2345’s picture

roam2345 commented
StatusFileSize
new 1802128.8-username-string-inconsistency-d8.patch56.44 KB

Missed string should now all pass the tests.

roam2345’s picture

roam2345 commented
Status: Needs work » Needs review

queue for testing

alansaviolobo queued 8: 1802128.8-username-string-inconsistency-d8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 8: 1802128.8-username-string-inconsistency-d8.patch, failed testing.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Issue summary: View changes
Issue tags: +Amsterdam2014

Working on a reroll

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs work » Needs review
StatusFileSize
new username-string-inconsistency-d8-1802128-13.patch93.14 KB

I've rerolled the patch.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented

But it's not a "user name", its a username. It's #1 that should be rerolled.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs review » Needs work

The last submitted patch, 13: username-string-inconsistency-d8-1802128-13.patch, failed testing.

Status: Needs work » Needs review

legolasbo queued 13: username-string-inconsistency-d8-1802128-13.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 13: username-string-inconsistency-d8-1802128-13.patch, failed testing.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs work » Needs review

Rerolled the first patch.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented

I meant that it's the patch in #1 (the D7) patch that should be ported to D8.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
StatusFileSize
new user-username_string_inconsistency-1802128-19.patch2.24 KB

I forgot to upload the patch, sorry.

Status: Needs review » Needs work

The last submitted patch, 21: user-username_string_inconsistency-1802128-19.patch, failed testing.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs work » Needs review
StatusFileSize
new string_inconsistency-1802128-23.patch20.28 KB

I missed a "name", while looking for it i also found numerous "user name(s)" which i also replaced for consistency.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: String inconsistency » Replace "user name" with "username" in UI text
Status: Reviewed & tested by the community » Fixed

Google Fight and http://english.stackexchange.com/questions/43436/username-user-name-or-u... seem to back this up as well.

Committed and pushed to 8.x. Thanks!

  • webchick committed cd31649 on 8.0.x 
    Issue #1802128 by legolasbo, jucallme: Fixed Replace "user name" with "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.