Clean up CSS files [#1800010]

The CSS files are a little untidy and need a bit of cleaning up.

Comment	File	Size	Author
#4	aloha-clean-css-1800010_2.patch	15.84 KB	psynaptic
#2	aloha-clean-css-1800010_1.patch	15.81 KB	psynaptic
#1	aloha-clean-css-1800010.patch	18.85 KB	psynaptic

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

psynaptic CreditAttribution: psynaptic commented 1 October 2012 at 16:05

Status:

Active

» Needs review

File	Size
aloha-clean-css-1800010.patch	18.85 KB

I haven't changed any behaviour with this patch to keep it easy to review, only code style and general standards.

File	Size
aloha-clean-css-1800010_1.patch	15.81 KB

Comment #3

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 1 October 2012 at 16:30

Status:

Needs review

» Needs work

+++ b/css/aloha-drupal-ui-rtl.cssundefined
@@ -3,38 +3,42 @@
+ * Toolbar tabs

Trailing period is missing here and elsewhere.

+++ b/css/aloha-drupal-ui-rtl.cssundefined
@@ -3,38 +3,42 @@
+

I used lack of newlines to group things. That's not a core practice, I presume?

+++ b/css/aloha-drupal-ui-rtl.cssundefined
@@ -3,38 +3,42 @@
+  border-left: 1px solid #aaa;

Why lowercase? I'm not sure where I picked it up, but I've been told this is better + the core standard?

+++ b/css/aloha-drupal-ui-rtl.cssundefined
@@ -3,38 +3,42 @@
+ * Format dropdown

"multisplit" should still be mentioned.

+++ b/css/aloha-drupal-ui.cssundefined
@@ -64,7 +64,7 @@
-  opacity: 0.3;
+  opacity: .3;

Good :) I missed this one.

+++ b/css/aloha-drupal-ui.cssundefined
@@ -179,46 +190,66 @@
-  background: -moz-linear-gradient(rgb(254,254,254) 0%,rgb(204,204,204) 100%);
-  background: -webkit-gradient(linear,color-stop(0, rgb(254,254,254)),color-stop(1, rgb(204,204,204)));
-  background: -webkit-linear-gradient(rgb(254,254,254) 0%,rgb(204,204,204) 100%);
-  background: -o-linear-gradient(rgb(254,254,254) 0%,rgb(204,204,204) 100%);
-  background: linear-gradient(rgb(254,254,254) 0%,rgb(204,204,204) 100%);
+  background: -webkit-gradient(
+    linear,
+    color-stop(0, rgb(254, 254, 254)),
+    color-stop(1, rgb(204, 204, 204))
+  );
+  background: -webkit-linear-gradient(rgb(254, 254, 254) 0%, rgb(204, 204, 204) 100%);
+  background:    -moz-linear-gradient(rgb(254, 254, 254) 0%, rgb(204, 204, 204) 100%);
+  background:      -o-linear-gradient(rgb(254, 254, 254) 0%, rgb(204, 204, 204) 100%);
+  background:         linear-gradient(rgb(254, 254, 254) 0%, rgb(204, 204, 204) 100%);

This CSS was autogenerated by some design app of @tkoleary, thanks for the excellent clean-up :)

Comment #4

psynaptic CreditAttribution: psynaptic commented 1 October 2012 at 16:51

Status:

Needs work

» Needs review

File	Size
aloha-clean-css-1800010_2.patch	15.84 KB

Trailing period is missing here and elsewhere.

I think trailing period is only necessary if it is a sentence. If it's just a noun then it's not specifically required to be proper English. I have debated this over the space of about a year with some pretty clued-up people (including Morbus) and the consensus is that it's not always needed as explained above.

Come to think of it, I guess these could work with a full stop. I've adjusted the patch.

I used lack of newlines to group things. That's not a core practice, I presume?

Either is fine (both are found in core) but I much prefer the less dense version. If you need to group things then by definition they should have a title. I read a book on code style and it said something like "if in doubt, always prefer less dense code". The assumption is that it makes it more readable.

Why lowercase? I'm not sure where I picked it up, but I've been told this is better + the core standard?

Unfortunately, both upper- and lowercase are used in core (both in the same file no less e.g., modules/block/block.css). Using lowercase is "preferred" by the CSS coding standards.