Database cache backend catches Exception instead of PDOException, which makes it catch other errors and hide real problems.

Looking at the code most people may say it's not a problem because the only thing which is called is the database, but working on #1748022: Make cache()->get() return a classed CacheItem object I experienced various other exceptions being catched while they shouldn't making the unit testing really hard to debug until I found that out.

CommentFileSizeAuthor
#3 1799908-3-cache_database_database_exception.patch1.78 KBpounard
#1 1799908-1-cache_database_pdo_exception.patch1.36 KBpounard
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented
Status: Active » Needs review
FileSize
1799908-1-cache_database_pdo_exception.patch1.36 KB

Status: Needs review » Needs work

The last submitted patch, 1799908-1-cache_database_pdo_exception.patch, failed testing.

pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented
Title: Database cache backend catches Exception instead of PDOException » Database cache backend catches Exception instead of DatabaseExceptionWrapper
Status: Needs work » Needs review
FileSize
1799908-3-cache_database_database_exception.patch1.78 KB

Should catch DatabaseExceptionWrapper instead of PDOException.

alansaviolobo queued 3: 1799908-3-cache_database_database_exception.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: 1799908-3-cache_database_database_exception.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes
Status: Needs work » Closed (outdated)
Related issues: +#1792536: Remove the install backend and stop catching exceptions in the default database cache backend