This seems to be an issue with drupal_get_form() being passed straight in to drupal_render()

e.g. $o = drupal_render(drupal_get_form('stormproject_list_filter', $filterdesc));

Files: 
CommentFileSizeAuthor
#10 storm-1799432-drupal_render.patch4.65 KBwillwh
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]
#9 storm-1799432-drupal_render-9.patch4.65 KBjuliangb
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]
#5 1799432-drupal_render-4.patch9.53 KBwillwh
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]
#1 storm-drupal_render-1799432-2.patch9.66 KBwillwh
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]

Comments

willwh’s picture

Status:Active» Needs review
StatusFileSize
new9.66 KB
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]

Here's a very simple patch for these - is this the correct way to deal with this? :)

kfritsche’s picture

I wonder that this works with D6 :P

But this should be the correct way.

juliangb’s picture

Sensible change - but could we get rid of the trailing whitespace please?

juliangb’s picture

Status:Needs review» Needs work

Just tried to redo this myself, and found the patch file is corrupted.

Are you able to repost at all?

willwh’s picture

Status:Needs work» Needs review
StatusFileSize
new9.53 KB
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]

Sure thing, should have removed whitespace too :)

juliangb’s picture

Status:Needs review» Needs work

William,

I'm still having some trouble reading (machine reading!) your patches - were they created using the process described at http://drupal.org/node/707484?

Also noticed the testbot says that no files were affected by the patch - means that it isn't reading them either!

Might have come back to these before your part of the world wakes up, but happy to help figure out what's going on here.

Thanks,
Julian

willwh’s picture

Hi julian, I'm using powershell in windows, git diff 7.x-.1x > whatever.patch

I'll try making patches straight from eclipse - or just jump over to a nix box and work from there :)

p.s. still haven't seen you in IRC ;)

juliangb’s picture

Ah windows... might be the line endings.

[snip from the handbook]

Line endings and directory separators

Note for Windows users: Use Unix line endings (LF) and directory separators (/). Many text editors can convert line endings, or you can pipe diff output through dos2unix.

[/snip]

juliangb’s picture

Status:Needs work» Needs review
StatusFileSize
new4.65 KB
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]

Let's try this one.

willwh’s picture

StatusFileSize
new4.65 KB
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]

Let's try again :)

juliangb’s picture

Status:Needs review» Fixed

Committed - thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.