Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Both #1452188: New UI for string translation and #1445004: Implement customized translation bit on translations updated selectors in locale.admin.css (formerly locale.css), but didn't fully update locale-rtl.css or rename it to locale.admin-rtl.css.
locale.admin.css
.locale-translate-filter-form .form-item-langcode,
.locale-translate-filter-form .form-item-translation,
.locale-translate-filter-form .form-item-customized {locale-rtl.css
.locale-translate-filter-form .form-item-language,
.locale-translate-filter-form .form-item-translation,
.locale-translate-filter-form .form-item-group {Proposed resolution
The patch in #1 corrects the discrepancies and renames locale-rtl.css to locale.admin-rtl.css. Before applying this patch, an RTL version of locale.admin.css will never be included - see language_css_alter().
Remaining tasks
Patch needs reviews.
User interface changes
The RTL styles for Locale will correctly be applied.
Before:
After:
API changes
n/a
Original report by Cottser
#1452188: New UI for string translation and #1445004: Implement customized translation bit on translations updated locale.admin.css (formerly locale.css), but didn't fully update locale-rtl.css.
Attached patch corrects this and renames locale-rtl.css to locale.admin-rtl.css.
Cross-linking with #1663130: Clean up css in Locale.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1799124-1-before.png | 32.78 KB | andymartha |
| #7 | 1799124-1-after.png | 30.89 KB | andymartha |
| #5 | 1799124-locale_rtl-before.png | 24.04 KB | star-szr |
| #5 | 1799124-locale_rtl-after.png | 24.16 KB | star-szr |
| #1 | 1799124-1.patch | 1.18 KB | star-szr |
Comments
Comment #1
star-szrRerolled patch. A couple other commits got things much closer, but the following group of selectors remains invalid, and the filename should be updated for consistency. language is now langcode, group is now customized.
Comment #3
star-szr#1: 1799124-1.patch queued for re-testing.
Comment #4
star-szrUpdated the issue summary and title to more accurately reflect the problem. I didn't realize previously that locale-rtl.css just won't be included, so this is more serious than I initially thought.
Patch still applies.
Comment #4.0
star-szrUpdating issue summary to use template
Comment #4.1
star-szrClarifying that no RTL stylesheet will be included
Comment #4.2
star-szrUpdated issue summary.
Comment #5
star-szrAdded some screenshots to the issue summary.
Comment #6
star-szrComment #7
andymartha CreditAttribution: andymartha commentedI can confirm that the issue described in #1 occurs in a fresh installation of Drupal 8.x-dev; the page at admin/config/regional/translate is not right to left when the language is set to right to left. See screenshot.
After applying the patch 1799124-1.patch in #1 by Cottser, the page at admin/config/regional/translate IS right to left when the language is set that way. See screenshot.
Comment #8
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #9.0
(not verified) CreditAttribution: commentedAdding screenshots to summary