Fixed groupwise max relationship

No clue what this feature does, so I can't rly review so I just scrolled through it...

+++ b/lib/Drupal/views/Tests/Taxonomy/TaxonomyTestBase.phpundefined
@@ -124,22 +101,23 @@ class RelationshipNodeTermDataTest extends ViewTestBase {
+    $term = entity_create('taxonomy_term', array(
+      'name' => $this->randomName(),
+      'description' => $this->randomName(),
+      // Use the first available text format.
+      'format' => db_query_range('SELECT format FROM {filter_format}', 0, 1)->fetchField(),
+      'vid' => $this->vocabulary->vid,
+      'langcode' => LANGUAGE_NOT_SPECIFIED,
+    ));
+    taxonomy_term_save($term);

Didn't knew you had to save stuff after using entity_create, interesting...
Reading the entity_create docs I don't think we have to save it again.
And if we save it we should do $term->save()

+++ b/tests/views_test_config/config/views.view.test_groupwise_term.ymlundefined
@@ -0,0 +1,66 @@
+core: 8.0-dev

Hmm I think it's better to change this to 8.0 or whatevar we are using elsewhere

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.phpundefined
@@ -161,10 +162,9 @@ public function buildOptionsForm(&$form, &$form_state) {
+    $view = new ViewExecutable($view);
+    $view->storage->addDisplay('default');
     return $view;

I would do

$view->addDisplay('default');
return $view->getExecutable();

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.phpundefined
@@ -219,20 +219,24 @@ function left_query($options) {
 
+
     // Add the base table ID field.

Extra line

+++ b/core/modules/views/lib/Drupal/views/Tests/Taxonomy/RelationshipNodeTermDataTest.phpundefined
@@ -2,7 +2,7 @@
- * Definition of Drupal\views\Tests\Taxonomy\RelationshipNodeTermDataTest.
+ * Definition of Drupal\views\Tests\Taxonomy\TaxonomyTestBase.

This looks wrong

+++ b/core/modules/views/lib/Drupal/views/Tests/Taxonomy/TaxonomyTestBase.phpundefined
@@ -22,35 +22,11 @@ class RelationshipNodeTermDataTest extends ViewTestBase {
+  public $node;

@@ -63,7 +39,8 @@ function setUp() {
+    $this->nodes[] = $this->drupalCreateNode($node);
+    $this->nodes[] = $this->drupalCreateNode($node);

These should agree

+++ b/core/modules/views/lib/Drupal/views/Tests/User/RelationshipRepresentativeNode.phpundefined
@@ -0,0 +1,50 @@
+  public static $modules = array('node');

Node is in the testing profile

#13: views-1799040-13.patch queued for re-testing.

+++ b/lib/Drupal/views/Tests/Taxonomy/TaxonomyTestBase.phpundefined
@@ -22,48 +22,39 @@ class RelationshipNodeTermDataTest extends ViewTestBase {
+  protected $term2;
 
   function setUp() {
     parent::setUp();
     $this->mockStandardInstall();
 
-    $this->term_1 = $this->createTerm();
-    $this->term_2 = $this->createTerm();
+    $this->term1 = $this->createTerm();
+    $this->term2 = $this->createTerm();

Nitpick: Why no underscores now?

+++ b/lib/Drupal/views/Tests/Taxonomy/TaxonomyTestBase.phpundefined
@@ -124,22 +115,23 @@ class RelationshipNodeTermDataTest extends ViewTestBase {
+  protected function createTerm() {
+    $term = entity_create('taxonomy_term', array(
+      'name' => $this->randomName(),
+      'description' => $this->randomName(),
+      // Use the first available text format.
+      'format' => db_query_range('SELECT format FROM {filter_format}', 0, 1)->fetchField(),
+      'vid' => $this->vocabulary->vid,
+      'langcode' => LANGUAGE_NOT_SPECIFIED,
+    ));
+    $term->save();
+    return $term;

I also added a createTerm method in Drupal\views\Tests\DefaultViewsTest. Should we consider moving this to one of the base classes?

Otherwise, this looks good!

I'm happy with a follow up for that.

I'm not sure about the underscores. I would always use them and thought we were in general using underscores but I could totally be wrong on that :)

Class properties = no underscores :)

Looks like this is already fixed.