The three parameters in WebTest::getInfo() ['name', 'description', and 'group'] should be plain English strings There are a few core tests that still wrap these parameters in t().

This issue is to address two occurances of this in the Database subsystem. This then should be backported to D7.

Files: 
CommentFileSizeAuthor
#10 Remove_t_from_params_in_getinfo-1798858-D7-10.patch1.56 KBparanojik
PASSED: [[SimpleTest]]: [MySQL] 39,513 pass(es).
[ View ]
#2 Remove_t_from_params_in_getinfo-1798858-2.patch1.96 KBparanojik
PASSED: [[SimpleTest]]: [MySQL] 42,118 pass(es).
[ View ]

Comments

Lars Toomre’s picture

Title:Remove t() from parameters in getInfo() in tests» Remove t() from parameters in getInfo() in Database system

The two tests that need to be addressed are:

- EmptyStatementTest.php
- NextIdTest.php

paranojik’s picture

Status:Active» Needs review
StatusFileSize
new1.96 KB
PASSED: [[SimpleTest]]: [MySQL] 42,118 pass(es).
[ View ]

There you go...

Lars Toomre’s picture

Status:Needs review» Reviewed & tested by the community

Looks great! Thank you. RTBC!

DamienMcKenna’s picture

Component:documentation» database system

*cough* not a documentation issue

jhodgdon’s picture

But it's a good patch, thanks!

Committed to 8.x. Most likely we need to figure out where this test is in D7 and backport? If it doesn't exist, just set this back to 8.x/fixed. Thanks! [Lars: there's a tag for backporting. :) ]

Lars Toomre’s picture

OK @DamienMcKenna. I am at a loss why this is not a documentation issue.

If you care, please review the meta issue #500866: [META] remove t() from assert message and add comments as appropriate.

jhodgdon’s picture

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)
Issue tags:+Novice, +needs backport to D7
Lars Toomre’s picture

Version:7.x-dev» 8.x-dev
Status:Patch (to be ported)» Reviewed & tested by the community
Issue tags:-Novice, -needs backport to D7

Sorry x-post.

jhodgdon’s picture

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)
Issue tags:+Novice, +needs backport to D7

Now it's really a cross-post. :)

paranojik’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new1.56 KB
PASSED: [[SimpleTest]]: [MySQL] 39,513 pass(es).
[ View ]

...and there's the D7 backport...

jhodgdon’s picture

Assigned:Unassigned» jhodgdon
Status:Needs review» Reviewed & tested by the community

Thanks! I'll get that one committed tomorrow probably.

jhodgdon’s picture

Assigned:jhodgdon» Unassigned
Status:Reviewed & tested by the community» Fixed

Committed to 7.x - thanks again!

Automatically closed -- issue fixed for 2 weeks with no activity.