Files: 
CommentFileSizeAuthor
#17 drupal_js_cache_files-1798724-17.patch2.6 KBAlbert Volkman
PASSED: [[SimpleTest]]: [MySQL] 46,390 pass(es).
[ View ]
#14 13-14-interdiff.txt801 bytesalexpott
#14 drupal_js_cache_files-1798724-14.patch3.12 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 46,224 pass(es).
[ View ]
#13 drupal_js_cache_files-1798724-13.patch3.13 KBAlbert Volkman
PASSED: [[SimpleTest]]: [MySQL] 46,223 pass(es).
[ View ]
#13 interdiff.txt525 bytesAlbert Volkman
#11 drupal_js_cache_files-1798724-11.patch3.13 KBAlbert Volkman
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/system.install.
[ View ]
#11 interdiff.txt2.6 KBAlbert Volkman
#9 1798724-drupal_js_cache_files_4.patch3.1 KBandreiashu
PASSED: [[SimpleTest]]: [MySQL] 41,912 pass(es).
[ View ]
#5 1798724-drupal_js_cache_files_3.patch2.56 KBandreiashu
PASSED: [[SimpleTest]]: [MySQL] 41,897 pass(es).
[ View ]
#3 1798724-drupal_js_cache_files_2.patch2.59 KBandreiashu
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1798724-drupal_js_cache_files_2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#1 1798724-drupal_js_cache_files_1.patch2.59 KBandreiashu
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1798724-drupal_js_cache_files_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

andreiashu’s picture

Status:Active» Needs review
StatusFileSize
new2.59 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1798724-drupal_js_cache_files_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Let's see...

Status:Needs review» Needs work

The last submitted patch, 1798724-drupal_js_cache_files_1.patch, failed testing.

andreiashu’s picture

Status:Needs work» Needs review
StatusFileSize
new2.59 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1798724-drupal_js_cache_files_2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Removed the double space from drupal_build_js_cache()

Status:Needs review» Needs work

The last submitted patch, 1798724-drupal_js_cache_files_2.patch, failed testing.

andreiashu’s picture

Status:Needs work» Needs review
StatusFileSize
new2.56 KB
PASSED: [[SimpleTest]]: [MySQL] 41,897 pass(es).
[ View ]

Needed "git config core.filemode false"

andreiashu’s picture

@alexpott: I tested the '?:' operator and it works as advertised - the following code prints out default:

$val = NULL;
$new_val = $val ?: 'default';
print $new_val;
nod_’s picture

Issue tags:+JavaScript

tagging

alexpott’s picture

Status:Needs review» Needs work

Just realised that actually whilst this does not need an update function to migrate the variable we should be deleting the old variable in an update function so it is not left lying around.

I tested the patch and it works as expected.

andreiashu’s picture

Status:Needs work» Needs review
StatusFileSize
new3.1 KB
PASSED: [[SimpleTest]]: [MySQL] 41,912 pass(es).
[ View ]

Attached new patch with the hook update. Thanks for the review!

alexpott’s picture

Status:Needs review» Needs work

There's been some discussion around the namespace strategy for state key names on #1790920: Move cron_last, node_cron_last and common_test_cron to state system - the how to has been updated http://drupal.org/node/1787318

So in this instance we probably should change the key to system.drupal_js_cache_files

Albert Volkman’s picture

Status:Needs work» Needs review
StatusFileSize
new2.6 KB
new3.13 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/system.install.
[ View ]

Variable name updated with system namespace.

Status:Needs review» Needs work

The last submitted patch, drupal_js_cache_files-1798724-11.patch, failed testing.

Albert Volkman’s picture

Status:Needs work» Needs review
StatusFileSize
new525 bytes
new3.13 KB
PASSED: [[SimpleTest]]: [MySQL] 46,223 pass(es).
[ View ]

Forgot to update system_update_N() number.

alexpott’s picture

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new3.12 KB
PASSED: [[SimpleTest]]: [MySQL] 46,224 pass(es).
[ View ]
new801 bytes

Patch to bump system_update_N() number and fixes documentation. Looks good to go. Thanks for the work.

catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

sun’s picture

+++ b/core/includes/common.inc
@@ -4720,7 +4720,7 @@ function drupal_add_tabledrag($table_id, $action, $relationship, $group, $subgro
-  $map = variable_get('drupal_js_cache_files', array());
+  $map = state()->get('system.drupal_js_cache_files') ?: array();

Why didn't we remove the 'drupal_' prefix in the state name?

That prefix was previously used to (poorly) namespace the variable name to a non-existing "drupal" extension. The proper extension namespace is 'system' now, so it should be removed.

Albert Volkman’s picture

Status:Fixed» Needs review
StatusFileSize
new2.6 KB
PASSED: [[SimpleTest]]: [MySQL] 46,390 pass(es).
[ View ]

Here's a patch for that.

sun’s picture

Status:Needs review» Reviewed & tested by the community

Thanks!

catch’s picture

Status:Reviewed & tested by the community» Fixed

Thanks! Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.