Files: 
CommentFileSizeAuthor
#13 1797330-13-t-help.patch2.77 KBdcam
PASSED: [[SimpleTest]]: [MySQL] 40,484 pass(es). View
#9 1797330-9-t-help.patch1.08 KBLars Toomre
PASSED: [[SimpleTest]]: [MySQL] 41,902 pass(es). View
#5 help-1797330-3.patch2.84 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 41,698 pass(es). View
#5 interdiff.txt846 bytesxjm
#1 help-1797330-1.patch2.84 KBxjm
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/help/lib/Drupal/help/Tests/HelpTest.php. View

Comments

xjm’s picture

Assigned: xjm » Unassigned
Status: Active » Needs review
Issue tags: +needs backport to D7
FileSize
2.84 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/help/lib/Drupal/help/Tests/HelpTest.php. View

Very little to clean up, but I cleaned up a couple that were using t() around weird string concatenation (and nonsense square brackets) to instead use format_string() with proper italicized placeholders.

xjm’s picture

Title: Remove t() from assertion messages in tests for the image module » Remove t() from assertion messages in tests for the help module

Oops.

xjm’s picture

Component: image.module » help.module

xjm sighs.

Status: Needs review » Needs work

The last submitted patch, help-1797330-1.patch, failed testing.

xjm’s picture

Status: Needs work » Needs review
FileSize
846 bytes
2.84 KB
PASSED: [[SimpleTest]]: [MySQL] 41,698 pass(es). View

Derp.

Lars Toomre’s picture

Status: Needs review » Reviewed & tested by the community

Oh this one was short and easy...

All of the changes in this patch are correct and appropriate. It includes format_string() changes which also were good.

Hence RTBC!

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

jhodgdon’s picture

Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

This needs backporting to D7. Also, can someone confirm everything was fixed in D8 and move this back there if not?

Lars Toomre’s picture

Version: 7.x-dev » 8.x-dev
Status: Patch (to be ported) » Needs review
FileSize
1.08 KB
PASSED: [[SimpleTest]]: [MySQL] 41,902 pass(es). View

Reviewing the resulting help test messages by hand, I see that we missed on t() removal. Attached is a patch that needs to be attached to D8 before backport.

dcam’s picture

Status: Needs review » Reviewed & tested by the community

I tested #9. I didn't find any other t()'s around Help module test assert messages. Marking as RTBC.

webchick’s picture

Assigned: Unassigned » jhodgdon

Tum te tum...

jhodgdon’s picture

Version: 8.x-dev » 7.x-dev
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks! That one's in; back to backport (#5 + #9).

dcam’s picture

Status: Patch (to be ported) » Needs review
FileSize
2.77 KB
PASSED: [[SimpleTest]]: [MySQL] 40,484 pass(es). View

Backported #5 and #9 to D7.

dcam’s picture

#13: 1797330-13-t-help.patch queued for re-testing.

dcam’s picture

Issue tags: +Novice

Tagging as Novice.

jhodgdon’s picture

#13: 1797330-13-t-help.patch queued for re-testing.

lazysoundsystem’s picture

Status: Needs review » Reviewed & tested by the community

This looks good. RTBC.

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Thanks again all! Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Removing myself from the author field so I can unfollow. --xjm