Back in #1760284: Rewrite ViewListController to use the core EntityListController, the "views template" (dynamic default views) UI was disabled. With the move to YAML, if we want that functionality, we'd likely need to rewrite it from the ground up. Sounds like a great job for D8 contrib!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
11.27 KB

In addition, this re-adds some code I misunderstood :)

Status: Needs review » Needs work

The last submitted patch, views-1796182-1.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
10.85 KB

Hm, nevermind.

xjm’s picture

I confirmed that all this code is only related to itself. :)

[lorentz:views | Wed 21:22:37] $ grep -r "views_get_all_templates" *
includes/admin.inc:  $templates = views_get_all_templates();
views.module:function views_get_all_templates() {
views_ui.module:    'type' => views_get_all_templates() ? MENU_LOCAL_ACTION : MENU_VISIBLE_IN_BREADCRUMB,
[lorentz:views | Wed 21:22:39] $ grep -r "views_ui_add_template_page" *
includes/admin.inc:function views_ui_add_template_page() {
views_ui.module:    'page callback' => 'views_ui_add_template_page',
[lorentz:views | Wed 21:23:29] $ grep -r "_views_templates" *
modules/node.views_template.inc:function node_views_templates() {
views.module:    $function = $module . '_views_templates';
xjm’s picture

Status: Needs review » Reviewed & tested by the community

Checked in #1760284: Rewrite ViewListController to use the core EntityListController. The test coverage for this functionality was removed there, as was the implementation in ViewsUI::init() and ViewsUI::add_template_page(). (See comment #26 in that issue.)

tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.