Greetings,

I'm using your module in my Video portal and came across with the following inconvenience - all permissions are built using content type human-readable names. So, if I have a 'video' content type with 'Home Video' name the create permission for one of its groups will be like this 'create Home Video group_editor_fields' instead of 'create video group_editor_fields'.

I think it is not good to use human names in permission internal names.
'Home Video' name can be changed any time by administrator. This will break a snippet like this:

	if (!user_access('create Home Video group_editor_fields')) {

Please, consider to use content type machine names for permissions. Thanks.

Comments

mholloway’s picture

mholloway CreditAttribution: mholloway commented

Potential one-line fix?

We had the same problem and changed this:

$output = $verb . " " . $content_types[$content_type]['name'] . " " . $content_types[$content_type]['fields'][$field_name]['widget']['label'];

to this:

$output = $verb . " " . $content_types[$content_type]['name'] . " " . $field_name;

It seems to work but is not yet thoroughly tested. Use at your own risk :)