Feed: "Attach to" form doesn't display all the displays

I'll get some tests for this.

Maybe this for the passing one instead...I think I was over zealous with adding ->storage in.

Don't want to spoil the party but maybe we have more bugs left that are related to this. Srry for the huge paste!

C:\xampp\htdocs\views\views.api.php
     751   *   $handler =& $view->display['DISPLAY_ID']->handler;
1 match in C:\xampp\htdocs\views\views.api.php
C:\xampp\htdocs\views\views.module
    1554        $plugin = views_get_plugin_definition('display', $view->display[$id]['display_plugin']);
1 match in C:\xampp\htdocs\views\views.module
C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\HandlerBase.php
     332      $form['#title'] = check_plain($view->display[$display_id]['display_title']) . ': ';
1 match in C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\HandlerBase.php
C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\display\Attachment.php
      93        if (!empty($this->view->display[$display])) {
      94          $attach_to = check_plain($this->view->display[$display]['display_title']);
     252        $view->display_handler->usesPager = $this->view->display[$display_id]->handler->usesPager();
     253        $view->display_handler->setOption('pager', $this->view->display[$display_id]->handler->getOption('pager'));
4 matches in C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\display\Attachment.php
C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\display\DisplayPluginBase.php
    1227        $link_display = empty($this->view->display[$display_id]) ? t('None') : check_plain($this->view->display[$display_id]['display_title']);
2 matches in C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\display\DisplayPluginBase.php
C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\display\Feed.php
     154        if (!empty($this->view->display[$display])) {
     155          $attach_to = check_plain($this->view->display[$display]['display_title']);
2 matches in C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\display\Feed.php
C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\relationship\GroupwiseMax.php
     130        if ($view->base_table == $this->definition['base'] && !empty($view->display['default']['display_options']['fields'])) {
     197        unset($temp_view->display['default']['display_options']['fields']);
2 matches in C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\relationship\GroupwiseMax.php
C:\xampp\htdocs\views\lib\Drupal\views\Tests\ViewStorageTest.php
     249      $new_display = $view->display['test'];
     348      $this->assertEqual($view->display[$id]['display_title'], $random_title);
     353      $this->assertEqual($view->display[$id]['display_title'], $random_title);
     356      $this->assertEqual($view->display[$id]['display_title'], 'Page 3');
4 matches in C:\xampp\htdocs\views\lib\Drupal\views\Tests\ViewStorageTest.php
C:\xampp\htdocs\views\theme\theme.inc
     133  //            'view_base_path' => isset($view->display['page']) ? substr(url($view->display['page']['display_options']['path']), strlen($base_path)) : '',
2 matches in C:\xampp\htdocs\views\theme\theme.inc
C:\xampp\htdocs\views\views_ui\admin.inc
     994    $display = &$view->display[$display_id];
    2143          $plugin->init($view, $view->display[$display_id], $handler->options['style']['options']);
2 matches in C:\xampp\htdocs\views\views_ui\admin.inc

Yep, looks like alot of those need looking at.

Should this be another issue though? Fixing all of these isn't really related to the title :)

As long as there will be an issue for all those untested bugs, thats fine with me :)