I'm marking this as a bug as I really am frustrated by the number of times the QA servers pop up and complain about patches.

Don't get me wrong, this is a totally needed service.

It's entirely likely that I'm missing something. But as I said #504962-149: Provide a compound form element with accessible labels it works locally, so really no idea why it's failing here in the bot.
http://qa.drupal.org/pifr/test/343123

Surely, if a test fails here:
7. Detect a Drupal installation failure
Ensure that you can perform a fresh Drupal install.

It's not the fault of the patch which probably shouldn't even have been applied at that stage.

Maybe I'm missing something, but having some additional ideas on what might have failed would be good. Maybe it's a PHP issue, but that error seems unrelated to the patch.

Having some docs to help point folks in the right direction would be useful. I'm kinda lost as to whether this is just a bot behaving badly or if indeeed there's a problem with the code.

Comments

sun’s picture

Title: Drupal Quality Assurance Needs Better Error Messages » Failures in early test review environment setup need better error messages
Project: Drupal.org site moderators » Drupal.org Testbots
Component: Other » User interface
Issue tags: -qa

Moving to the correct project.

You can see the actual error message when opening the "Review log" fieldset and scrolling to the bottom of the command line log.

Your case, however, sounds like the testbot is not able to find/locate some expected input fields in the Drupal installer UI when performing an initial, manual installation of Drupal core.

jthorson’s picture

It's true that the early stages of testbot environment setup have very few opportunities to detect failures. This error message in particular is the first real opportunity that the bot has to perform a 'sanity check' ... generally speaking, the bot can't load up the site under test - that's not to say that the installation necessarily failed; but almost always, it means that Drupal is throwing a WSOD or PHP error message to the screen instead of the installation page.

In this particular case, it's a WSOD caused by:

PHP Fatal error: Call to undefined function drupal_attributes() in core/includes/form.inc on line 2797

mgifford’s picture

Thanks @sun.

So, since we aren't working with the Drupal Installer UI, is there anything we should be doing here to bump this along? Not sure what to do from:

[@reason] => Installing: failed to arrive at database configuration page using install path http://drupaltestbot813.2-mysql.osuosl.test/checkout/install.php?profile=standard&langcode=en

EDIT: Just saw #504962-156: Provide a compound form element with accessible labels - that all makes more sense now.

rfay’s picture

In the OP, note that this is almost always not the testbot's fault, and can almost always be detected by

1. Attempting to install with the given patch applied.
2. Running a tiny subset of the tests locally.

Please don't ever forget about local testing.

Note that Drupal itself does not give good feedback when an installation fails. And what the testbot is doing here is installing Drupal.

isntall’s picture

Project: Drupal.org Testbots » DrupalCI: Results (Modernizing Testbot Initiative)
Issue summary: View changes