Move code out of handlers.inc

Couldn't we move things to the HandlerBase if possible but still keep the functions in handlers.inc as we will not need this file on every page load?

+++ b/lib/Drupal/views/Plugin/views/HandlerBase.phpundefined
@@ -618,4 +621,317 @@ public function validate() { return array(); }
+  public function getSQLFormat($format) {
...
+  public function getSQLDateField() {

Why not making a static function?

+++ b/lib/Drupal/views/Plugin/views/HandlerBase.phpundefined
@@ -618,4 +621,317 @@ public function validate() { return array(); }
+    $offset = $this->getTimezone();

Can you actually call a static function like that?

+++ b/lib/Drupal/views/Plugin/views/HandlerBase.phpundefined
@@ -618,4 +621,317 @@ public function validate() { return array(); }
+   * Helper function to create cross-database SQL date formatting.

See my helper function remark

+++ b/lib/Drupal/views/Plugin/views/HandlerBase.phpundefined
@@ -618,4 +621,317 @@ public function validate() { return array(); }
+   * Helper function to create cross-database SQL dates.

Always start with a verb even if it's a helper function.

+++ b/lib/Drupal/views/Plugin/views/HandlerBase.phpundefined
@@ -618,4 +621,317 @@ public function validate() { return array(); }
+   *   will be used, i.e. $set_offset = 0 will make no timezone adjustment.
+   * @return
+   *   An appropriate SQL string for the db type and field type.

Newline before return

+++ b/lib/Drupal/views/Plugin/views/HandlerBase.phpundefined
@@ -618,4 +621,317 @@ public function validate() { return array(); }
+    if (!$handler) {
+      $handler = new \stdClass();

Makes me sad :(. This needs to die, we need an empty HandlerBase thingie

Some minor stuff

+++ b/lib/Drupal/views/Plugin/views/argument/Date.phpundefined
@@ -83,4 +83,63 @@ function get_sort_name() {
+   * Helper function to create cross-database SQL date extraction.

Srry missed that one