Integrate with Commerce decimal quantities [#1792648]

I want to create integration with Commerce decimal quantities.

To do this we need to provide additional javascript settings:

minimum value
step

And add this settings to administration UI.
On next week I will provide patch for this issue!

Comment	File	Size	Author
#2	commerce_extra_decimal-6511176-2.patch	7.48 KB	5n00py

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

5n00py CreditAttribution: 5n00py commented 23 September 2012 at 13:48

As I see setting for step already implemented in dev.
But if I set step value to 0.5 i get following error:
Warning: Division by zero in commerce_extra_quantity_validate_cardinality() (line 97 in sites/all/modules/contrib/commerce_extra/modules/quantity/commerce_extra_quantity.module).

Comment #2

5n00py CreditAttribution: 5n00py commented 28 September 2012 at 21:18

Status:

Needs work

» Needs review

File	Size
commerce_extra_decimal-6511176-2.patch	7.48 KB

As I say before I have patch that solving problems with commerce_decimal_quantities.
This patch do this things:

new setting called "minimum_value"
Append settings form(see above)(validation & submit also handled)
Update form alter for push setting to theme functions
Fix validation problem if minimum value rounding to zero(#1 - #1792648-1: Integrate with Commerce decimal quantities)
Update hook_theme(add variable to theme function)
Update theme function itself(this is place where we actually can send new argument to js)
Modify JS to deal with new "minimum_value" variable"

Comment #3

5n00py CreditAttribution: 5n00py commented 26 October 2013 at 08:31

Status:

Needs review

» Active

Should be reviewed after #1667642: Quantity decrease/increase functionality to be set in add to cart form formatter or .

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 18 May 2015 at 11:53

Assigned:	5n00py	» Unassigned
Issue summary:	View changes
Status:	Active	» Needs review

FYI the purpose if the "assigned" field is to indicate that you're actively working on the issue, if you've uploaded a patch and don't intend to do further work then you should un-assign the issue. Also, if there's a patch then you should also leave the issue as "needs review".