A new translations:// directory was recently created in #1658842: Introduce a translations:// stream wrapper to access the .po file directory. In the simpletest framework we create new directories for public://, private:// and temporary://. We should do the same for translations:// to ensure that tests run in a clean environment.

Without this I experience some strange interdependencies between the "Translation export" and "String translate, search and validate" (but only with my patch for #1393392: Convert prefix cache clears to cache tags, then remove support for them - I'm not sure why).

#5 translations-simpletest-4.patch6.03 KBc960657
PASSED: [[SimpleTest]]: [MySQL] 41,414 pass(es). View
#3 translations-simpletest-3.patch1.97 KBc960657
PASSED: [[SimpleTest]]: [MySQL] 41,410 pass(es). View
translations-simpletest-1.patch1.97 KBc960657
PASSED: [[SimpleTest]]: [MySQL] 41,417 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


penyaskito’s picture

Issue tags: +stream wrappers, +gettext, +D8MI, +sprint

Tagging for catching more attention.

penyaskito’s picture

Status: Needs review » Needs work

IMHO, if this is set at the TestBase class, we should remove any additional set up of this directory in LocaleExportTest and LocaleFileImportStatus at least (writing from the top of my head, maybe it's referenced in other tests too).

Otherwise, make sense to have some consistence here.

c960657’s picture

Status: Needs work » Needs review
1.97 KB
PASSED: [[SimpleTest]]: [MySQL] 41,410 pass(es). View

Agreed. I removed the file_prepare_directory() calls from the locale tests.

BTW, doesn't this line-up indicate an inconsistency in the naming of these variables?

     variable_set('file_public_path', $this->public_files_directory);
     variable_set('file_private_path', $this->private_files_directory);
     variable_set('file_temporary_path', $this->temp_files_directory);
+    variable_set('locale_translate_file_directory', $this->translation_files_directory);
attiks’s picture

Isn't the patch in #3 the same as the original one?

c960657’s picture

6.03 KB
PASSED: [[SimpleTest]]: [MySQL] 41,414 pass(es). View

Oops, try this one instead.

attiks’s picture

Status: Needs review » Reviewed & tested by the community

Nice work. Is looking good to me, RTBC, but would love to see another +1 by penyaskito and/or Gabor.

chx’s picture

Thanks for fixing this -- and I think I haven't you see in a while -- c960657 , welcome back!

c960657’s picture

Thanks! I haven't really been away, but I have been running on low steam for quite some time. But recently my addiction has come back :-)

Gábor Hojtsy’s picture

Issue tags: +language-base

Looks good to me.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Looks straight-forward. Nice to see you "addicted" again, c960657! :)

Committed and pushed to 8.x. Thanks!

Gábor Hojtsy’s picture

Issue tags: -sprint

Superb, thanks all!

Automatically closed -- issue fixed for 2 weeks with no activity.