The menu callback for node/%node/moderation/diff/view is missing an argument which breaks things for me in Diff 7.x-3.0-alpha1.

CommentFileSizeAuthor
#1 workbench_moderation-diff_missing_argument-1791898-1.patch502 bytesrocketeerbkw
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rocketeerbkw’s picture

rocketeerbkw CreditAttribution: rocketeerbkw commented
Status: Active » Needs review
FileSize
workbench_moderation-diff_missing_argument-1791898-1.patch502 bytes

Not sure which branch to work against in 7.x-2.x or if you need one for it too. Here's one for 7.x-1.x.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Needs work

#1833950: Better Workbench Moderation integration

sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital commented
Issue summary: View changes
Status: Needs work » Needs review

The patch applies cleanly and works with Workbench Moderation 7.x-1.3 and Diff 7.x-3.x-dev .

This should not be blocked by #1831524: Previous/Next revision does not show diffs or #1833950: Better Workbench Moderation integration.
If this issue get merged, the diff_diffs_show() function would get the correct argument which is good.
Then a separate issue could handle the navigation / state links.

iSoLate’s picture

iSoLate CreditAttribution: iSoLate at Randstad Digital for Government of Flanders commented
Status: Needs review » Reviewed & tested by the community

Works nicely.

Tess Bakker’s picture

Tess Bakker
they/them
Primary language Dutch
CreditAttribution: Tess Bakker at ezCompany commented
Version: 7.x-1.x-dev » 7.x-3.x-dev

Moving this to 7.x-3.x, patch still needed and works with dev

wildfeed’s picture

wildfeed CreditAttribution: wildfeed as a volunteer commented

Please merge this patch into 7.x-3.x-dev