Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.http://drupal.org/project/encrypt/testing-status claims that there are coder issues in 7.x-2.x so we should fix those.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 1791724_coder_errors_2.patch | 6.29 KB | greggles |
| #1 | 1791724_coder_errors.patch | 7.21 KB | greggles |
Comments
Comment #1
gregglesI plan to commit this a little faster than I might normally do it since I'm hopefully this will make the testbot happier (and I want a happy testbot).
The changes I'm least confident about are:
1. Whether the inconsistent use of !link and !url in t() messages should be fixed in the way I've fixed it (I think it probably should).
2. Whether we should really use drupal_strlen and drupal_substr in plugins/encryption_methods/default.inc
Comment #2
gregglesI ran the tests locally and apparently those strlen and substr are important to keep as normal ones and not the drupal versions.
Comment #4
gregglesOK, now committed http://drupalcode.org/project/encrypt.git/commit/7c6e645 and http://drupalcode.org/project/encrypt.git/commit/519edb3