I am new to Drupal and worked on this module with my mentors, RoySegall and liberatr. We found that with the entity example module's delete links, there was no confirmation message.

I think it would be a great addition to have an options tab along with the delete link that gives you the confirmation to avoid mistakes.
entity example delete option screenshot
Please check the patch I have attached for errors. This is my first attempt at patching so any comments would be appreciated! Thanks!

-Tierra

CommentFileSizeAuthor
#1 added_delete_confirmation-0.patch2.89 KBIvoryTierra
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

IvoryTierra’s picture

Issue summary: View changes

Updated issue summary.

IvoryTierra’s picture

Whoops I forgot the patch.

Status: Needs review » Needs work

The last submitted patch, added_delete_confirmation-0.patch, failed testing.

rfay’s picture

Congratulations on your first patch! You'll need to run the tests locally and work out the test problem. Improvements to the tests are welcome as well.

Mile23’s picture

Component: Email Example » Entity Example
Mile23’s picture

Issue summary: View changes

Updated issue summary.

Mile23’s picture

Assigned: IvoryTierra » Unassigned
Issue summary: View changes

This patch should properly use confirm_form().

I can understand if the enthusiasm is a little stale. I'm unassigning this, but go ahead and re-assign if you'd like.

jungle’s picture

No activity for over 8 years. I am closing this. Please feel free to reopen if necessary.

Thanks!

jungle’s picture

Status: Needs work » Closed (outdated)