There are several references to the 'active store' in comments surrounding the configuration system right now. These need to be removed and replaced, I am going to suggest 'active configuration' as a replacement. The one exception is in DatabaseStorageTest.php where I would replace the line

'description' => 'Default active store for the configuration system.',

with

'description' => 'Database storage for the configuration system.',

Files: 
CommentFileSizeAuthor
#8 remove-active-store-refs-1788462-8.patch7.88 KBsamhassell
PASSED: [[SimpleTest]]: [MySQL] 42,329 pass(es). View
#6 remove-active-store-refs-1788462-6.patch7.88 KBsamhassell
PASSED: [[SimpleTest]]: [MySQL] 41,438 pass(es). View
#2 remove-active-store-refs-1788462-1.patch7.63 KBsamhassell
PASSED: [[SimpleTest]]: [MySQL] 41,319 pass(es). View

Comments

samhassell’s picture

Assigned: Unassigned » samhassell
samhassell’s picture

Status: Active » Needs review
FileSize
7.63 KB
PASSED: [[SimpleTest]]: [MySQL] 41,319 pass(es). View

Patch attached.

mheinke’s picture

michaellenahan’s picture

heyrocker’s picture

Status: Needs review » Needs work
+++ b/core/includes/config.incundefined
@@ -213,10 +213,10 @@ function config_import_invoke_owner(array $config_changes, StorageInterface $sou
+ * Exports configuration from the active configuration to staging.

This reads really awkwardly to me, but I'm not sure about what would be better.

+++ b/core/lib/Drupal/Core/Config/NullStorage.phpundefined
@@ -15,7 +15,7 @@ namespace Drupal\Core\Config;
- * able to short-circuit the full diff against the active store; the diff would

Nitpick but this is over 80 columns.

+++ b/core/modules/system/lib/Drupal/system/Tests/Module/ModuleTestBase.phpundefined
@@ -104,7 +104,7 @@ abstract class ModuleTestBase extends WebTestBase {
-    // Look up each default configuration object name in the active store, and

this one too

samhassell’s picture

Status: Needs work » Needs review
FileSize
7.88 KB
PASSED: [[SimpleTest]]: [MySQL] 41,438 pass(es). View

Rerolled with the changes.

"Exports configuration from the active configuration to staging."

How about "Exports the active configuration to staging."?

Gets rid of the redundant 'configuration'.

kbasarab’s picture

Status: Needs review » Needs work
+++ b/core/lib/Drupal/Core/Config/NullStorage.phpundefined
@@ -15,9 +15,9 @@ namespace Drupal\Core\Config;
+ * able to short-circuit the full diff against the active configuration; the ¶
+ * diff would yield all currently available configuration as items to remove, ¶

Trailing whitespace on these two lines.

+++ b/core/modules/system/lib/Drupal/system/Tests/Module/ModuleTestBase.phpundefined
@@ -104,8 +104,8 @@ abstract class ModuleTestBase extends WebTestBase {
+    // Look up each default configuration object name in the active ¶

Trailing white space again.

I like "Exports the active configuration to staging."

samhassell’s picture

FileSize
7.88 KB
PASSED: [[SimpleTest]]: [MySQL] 42,329 pass(es). View

Removed trailing whitespace.

heyrocker’s picture

Status: Needs work » Reviewed & tested by the community

I think this is ready to go. Thanks!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice catch. Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.