By default, the acquia_agent module alerts with a WATCHDOG_ERROR level alert if the connection fails to the Acquia network service.

If you run cron at a short interval, then its not uncommon to get a few of these each day, and this can quickly cause noise in a mailbox, when the actual update may work on the next cron 5 minutes later, and there is really not a problem.

Attached patch adds a user tunable setting to alert after x time if the connector was not able to connect, rather than every time its not able to connect.

CommentFileSizeAuthor
acquia_agent.diff4.44 KBsingularo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented 
+++ b/acquia_agent/acquia_agent.moduleundefined
@@ -670,15 +670,25 @@ function _acquia_agent_request($url, $method, $data) {
+    // Check if we need to alert for the failure, based on the users users set time.

double users

+++ b/acquia_agent/acquia_agent.moduleundefined
@@ -670,15 +670,25 @@ function _acquia_agent_request($url, $method, $data) {
+    if (variable_get('acquia_agent_alert_success', 0) < (REQUEST_TIME - variable_get('acquia_agent_alert_threshold', 0))) {

alert_success < time - threshold? That sounds very unlogical. I think the naming of the variables should be revisited so they reflect the correct value inside.

acquia_agent_alert_last_success < REQUEST_TIME - acquia_agent_alert_threshold. Not 100% ok yet though

+++ b/acquia_agent/acquia_agent.moduleundefined
@@ -670,15 +670,25 @@ function _acquia_agent_request($url, $method, $data) {
+    // Everything worked, reset the alert variable, so the timeout is back at the users set time.

vague explanation

+++ b/acquia_agent/acquia_agent.pages.incundefined
@@ -535,6 +535,25 @@ function acquia_agent_settings_form($form, &$form_state, $banner) {
+      0 => t('Immediate (default behaviour)'), ¶

Some trailing spaces in this config block

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)

This branch of Acquia Connector is no longer supported, per the version policy on the project homepage. As such, I'm tentatively closing this issue.

If this issue still applies to a supported branch (currently 7.x-3.x, 8.x-1.x, or 8.x-2.x), please reopen and select the new target version. Thanks!