Using current dev of calendar I saw this notice:


    Notice: Undefined variable: node in calendar_plugin_row->explode_values() (line 558 of /opt/www/test7h.whs/modules/calendar/includes/calendar_plugin_row.inc).
    Notice: Trying to get property of non-object in calendar_plugin_row->explode_values() (line 558 of /opt/www/test7h.whs/modules/calendar/includes/calendar_plugin_row.inc).

I had a look and indeed $node is there but it is not defined anywhere in the function, looking at the code I decided that it should be changed to $entity, did that and the error went away.

Patch attached.

CommentFileSizeAuthor
calendar-calendar_plugin_row-node-bug.patch817 byteshutch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gribnif’s picture

Gribnif CreditAttribution: Gribnif commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community

This one is a no-brainer. RTBC.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Title: bug in calendar_row_plugin » undefined $node bug in calendar_row_plugin
Issue tags: +Quick fix

RTBC++

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

bump

geru’s picture

geru CreditAttribution: geru as a volunteer commented

This was found, fixed 5.5 years ago by @hutch. It has been reviewed and tested by @Gribniff and @joelpittet and the community for years now, and yet it still has not been committed. I'm trying to understand what the correct Drupal process is to get this committed so more people don't have the same problem.

If it is any help, I can confirm that this patch fixes an obvious and simple error. How can this patch get committed?

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

@geru maybe you can offer to co-maintain this project?

Documentation on how to do that:
https://www.drupal.org/node/251466
https://www.drupal.org/node/363367

darby3’s picture

darby3 CreditAttribution: darby3 commented

Thanks from 2018, patch works for me.

solideogloria’s picture

solideogloria CreditAttribution: solideogloria commented
Title: undefined $node bug in calendar_row_plugin » undefined $node bug in calendar_plugin_row
wylbur’s picture

wylbur CreditAttribution: wylbur commented
Parent issue: » #2568105: Plan for Calendar 7.x-3.6 release

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Reviewed & tested by the community » Fixed

Thanks, Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.