workbench_access_content.view.inc

<?php
$view
->human_name = 'Workbench Access Content';
?>

This is broken in all Workbench* modules.

Files: 
CommentFileSizeAuthor
#7 1780530-workbench-views-name.patch1.74 KBagentrickard
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1780530-workbench-views-name.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#7 1780530-wa-views-name.patch631 bytesagentrickard
PASSED: [[SimpleTest]]: [MySQL] 67 pass(es).
[ View ]
#7 1780530-wm-views-name.patch718 bytesagentrickard
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1780530-wm-views-name.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

agentrickard’s picture

Priority:Normal» Minor

Must be a Views API change.

hass’s picture

No, this not an API change. Look into the Workbench view code, please. The Human name is an empty string. This is the pretty name that is normally shown in the Views UI, but all Workbench modules are showing the machine name (not user friendly)

See Line 13:
http://drupalcode.org/project/workbench_access.git/blob/refs/heads/7.x-1...

hass’s picture

Status:Active» Needs review
agentrickard’s picture

Status:Needs review» Needs work

No patch to review.

agentrickard’s picture

Status:Needs work» Active
hass’s picture

Just overwrite line 13 in workbench_access_content.view.inc with the line in #0

agentrickard’s picture

Status:Active» Needs review
StatusFileSize
new718 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1780530-wm-views-name.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new631 bytes
PASSED: [[SimpleTest]]: [MySQL] 67 pass(es).
[ View ]
new1.74 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1780530-workbench-views-name.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Patches for all three modules. To be split into separate issues by OP.

Status:Needs review» Needs work

The last submitted patch, 1780530-wm-views-name.patch, failed testing.

hass’s picture

Status:Needs work» Reviewed & tested by the community
agentrickard’s picture

Pushed to Workbench Access.

91e69dc..f7c0c4d  7.x-1.x -> 7.x-1.x
agentrickard’s picture

Project:Workbench Access» Workbench
Status:Reviewed & tested by the community» Needs review

Moving to Workbench proper.

agentrickard’s picture

Project:Workbench» Workbench Moderation

Fixed in Workbench.

   9113549..6857511  7.x-1.x -> 7.x-1.x

The moderation team needs to take a look, since this may also affect 2.x branch.

hass’s picture

Version:7.x-1.x-dev» 7.x-2.x-dev
stevector’s picture

Status:Needs review» Closed (duplicate)