Commerce Coupon UI is not correctly validating the uniqueness of new coupon codes. $op is not being passed to the form by the menu callback and thus not to the validator.

Attached is a patch which fixes the menu callback.

Comments

pcambra’s picture

Status: Active » Needs work

Nice catch!
I think we need to track the update of coupons too, as you can change the coupon code once it is created

idflood’s picture

Status: Needs work » Needs review
FileSize
3.15 KB

Here is a patch wich adds the validation on the update step.

pcambra’s picture

Status: Needs review » Fixed

Committed, thanks both!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.