Create newsletters for existing nodes

+++ b/simplenews.moduleundefined
@@ -696,6 +700,32 @@ function simplenews_get_category_field($bundle_name) {
+  // Construct a query of all nodes of this content type
+  // minus all simplenews newsletters.
+  $query = db_select('node');
+  $query->condition('type', $type->type);
+  $query->leftJoin('simplenews_newsletter', 'sn', 'node.nid = sn.nid');
+  $query->where('sn.nid IS NULL');
+  $query->fields('node', array('nid'));
+  // Get an array of nids.
+  $simplenews_nodes = $query->execute()->fetchCol();
+  // Turn the array of nids into an array of node objects.
+  $simplenews_nodes = node_load_multiple($simplenews_nodes);
+  // For each node from this array save newsletter.
+  foreach ($simplenews_nodes as $simplenews_node) {
+    $simplenews_newsletter = (object) simplenews_newsletter_defaults($simplenews_node);
+    simplenews_newsletter_save($simplenews_newsletter);

This does not scale. Imagine this is done on a node type with 10k or 100k nodes.

Instead, we should probably default to an empty/default newsletter object in case a node does not explicitly have one. We probable removed that due to refactoring but didn't think of that use case. To avoid this from happening again, we need to have tests for this. This will require a new test class which does not enable simplenews.module in setUp() but first creates a node, then uses module_enable() to enable simplenews and then attempt to send the newsletter.

You can execute the tests locally, just enable Simpletest and then run the tests that failed on the testbot.

I haven't looked at the patch yet, but note that there can't be any API changes in 7.x-1.x as that version is stable now. So you either need to do it without changing the API or it can only happen in 7.x-2.x. Where #1309404: Convert Newsletter categories to custom entity is changing *a lot* and will be commited first. It might even partially solve this as a side effect.

Looking at the patch, the problem is that you're are changing *a lot* that is not relevant to this issue in any way, like removing t()'s. See http://webchick.net/please-stop-eating-baby-kittens why this is a problem.

For example, a lot of your changes are going to conflict unecessarly with the linked issue, which means that you will have to re-do it for 7.x-2.x.

Also, changing the structure of tests is IMHO an API change too. Someone might have written a test (maybe in another contrib module) that relies on e.g. the simplenews test base class. A way to do it as an API *addition* instead of a change would e.g. be a second, optional argument that would not add simplenews. Or just not depend on the base class and copy some code instead.