Support from Acquia helps fund testing for Drupal Acquia logo

Comments

crasherzvir’s picture

Issue tags: +code sprint drupal night ua 2012

started work

crasherzvir’s picture

Status: Active » Needs review
FileSize
1.1 KB
podarok’s picture

Status: Needs review » Needs work
+++ b/core/themes/stark/templates/aggregator/aggregator-wrapper.twig
@@ -1,20 +1,20 @@
-{#
-
-/**
- * @file
- * Default theme implementation to wrap aggregator content.
- *
- * Available variables:
- * - content: All aggregator content.
- * - page: Pager links rendered through theme_pager().
- *
- * @see template_preprocess()
- * @see template_preprocess_aggregator_wrapper()
- *
- * @ingroup themeable
- */
-#}
-<div class="{{attributes.class}}">
-  {{content}}
-  {{pager}}
-</div>

wrong patch!
there is no file before in repository

crasherzvir’s picture

podarok’s picture

+++ b/core/themes/stark/templates/aggregator/aggregator-wrapper.twig
@@ -0,0 +1,20 @@
+<div class="{{attributes['class']}}">
+  {{content}}
+  {{pager}}

should use whitespace beetween {{ and variable

crasherzvir’s picture

podarok’s picture

Status: Needs work » Reviewed & tested by the community

looks good

podarok’s picture

Status: Reviewed & tested by the community » Fixed

commited

podarok’s picture

Component: Code » Twig templates

commited into 8.x branch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Berdir’s picture

I am removing this template in #293318: Convert Aggregator feeds into entities because I think it's kinda useless and can be done using renderable arrays. Feel free to review/comment over there, need feedback from frontent people about how to improve that kinda long list of aggregator templates.

podarok’s picture

Issue tags: -code sprint drupal night ua 2012

#11 good to see here point to right comment with patch in the #293318: Convert Aggregator feeds into entities issue
and possibly converting to renderable would be good practice for minimizing template count during Twig conversion and it will be good example for developers