Problem/Motivation
My products are ebooks. The ebook product entity type has an Image field labeled "Cover" and placed above the "Description" field on the Manage Fields UI.
This product is expected to be a single variation per display node.
I have not asked IEF to refer to the referenced products as "Variations".
When the form gets rendered into a product display node form by IEF, it places this image field at the bottom of the form, labeled "Variation Image" rather than where it was placed and how it was labeled in the entity's Manage Fields UI.
Proposed resolution
IEF should render fields as they are represented in the target bundle.
Remaining tasks
User interface changes
IEF follows the field positioning and labels from the Manage Fields UI on the target bundle type.
API changes
Unknown.
Comment | File | Size | Author |
---|---|---|---|
#4 | 1778342-reduce-product-grouping.patch | 2.47 KB | bojanz |
#3 | ief fieldsets.png | 19.54 KB | giorgio79 |
product display node form.png | 51.61 KB | Ogredude | |
Product reference field settings.png | 69.94 KB | Ogredude | |
Product entity fields.png | 77.84 KB | Ogredude |
Comments
Comment #1
bojanz CreditAttribution: bojanz commentedI agree with this proposal.
I tried to remove all of the image special casing, and the results was really ugly (at least in Kickstart), so this will need to wait post-RC1.
Comment #2
bojanz CreditAttribution: bojanz commentedRelated commit, fixes the Variation label bug:
http://drupalcode.org/project/inline_entity_form.git/commitdiff/5ea22e0?...
Comment #3
giorgio79 CreditAttribution: giorgio79 commentedComing from #1462730: Make the product form pretty Hope you dont mind retitling with the probem at hand.
I noticed also that extra fieldsets are added by IEF. Would love IEF to stick with whatever field groups are configured for the Manage Field form of the product entity, and not add any fieldsets in there :)
Comment #4
bojanz CreditAttribution: bojanz commentedCommitted another fix: removed the float from the product details. This styling caused issues with very little gain, and it causes problems on the OP's screenshot too.
Attaching a patch that removes the product image grouping.
I've left the attributes VS everything else grouping because I believe it is genuinely useful and shouldn't cause issues (the complains were all about images).
Shiny (Kickstart admin theme) will need to be updated after this patch is committed, so this will have to wait for next IEF release.
Comment #5
bojanz CreditAttribution: bojanz commentedRetitling.
Comment #6
dudenhofer CreditAttribution: dudenhofer commentedJust pushed an update to Shiny to account for this update without breaking previous versions. So you can test against the latest dev release soon.
Comment #7
bojanz CreditAttribution: bojanz commentedThanks, Aaron. Looks good.
Committed!