Problem/Motivation

My products are ebooks. The ebook product entity type has an Image field labeled "Cover" and placed above the "Description" field on the Manage Fields UI.
Product entity fields.png

This product is expected to be a single variation per display node.

I have not asked IEF to refer to the referenced products as "Variations".
Product reference field settings.png

When the form gets rendered into a product display node form by IEF, it places this image field at the bottom of the form, labeled "Variation Image" rather than where it was placed and how it was labeled in the entity's Manage Fields UI.
product display node form.png

Proposed resolution

IEF should render fields as they are represented in the target bundle.

Remaining tasks

User interface changes

IEF follows the field positioning and labels from the Manage Fields UI on the target bundle type.

API changes

Unknown.

CommentFileSizeAuthor
#4 1778342-reduce-product-grouping.patch2.47 KBbojanz
#3 ief fieldsets.png19.54 KBgiorgio79
product display node form.png51.61 KBOgredude
Product reference field settings.png69.94 KBOgredude
Product entity fields.png77.84 KBOgredude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz’s picture

bojanz CreditAttribution: bojanz commented

I agree with this proposal.

I tried to remove all of the image special casing, and the results was really ugly (at least in Kickstart), so this will need to wait post-RC1.

bojanz’s picture

bojanz CreditAttribution: bojanz commented

Related commit, fixes the Variation label bug:
http://drupalcode.org/project/inline_entity_form.git/commitdiff/5ea22e0?...

giorgio79’s picture

giorgio79 CreditAttribution: giorgio79 commented
Title: Image fields not placed or labeled correctly » IEF should render fields as they are represented in the target bundle
FileSize
ief fieldsets.png19.54 KB

Coming from #1462730: Make the product form pretty Hope you dont mind retitling with the probem at hand.

I noticed also that extra fieldsets are added by IEF. Would love IEF to stick with whatever field groups are configured for the Manage Field form of the product entity, and not add any fieldsets in there :)

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Title: Reduce custom field grouping for products » IEF should render fields as they are represented in the target bundle
FileSize
1778342-reduce-product-grouping.patch2.47 KB

Committed another fix: removed the float from the product details. This styling caused issues with very little gain, and it causes problems on the OP's screenshot too.

Attaching a patch that removes the product image grouping.
I've left the attributes VS everything else grouping because I believe it is genuinely useful and shouldn't cause issues (the complains were all about images).

Shiny (Kickstart admin theme) will need to be updated after this patch is committed, so this will have to wait for next IEF release.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Title: IEF should render fields as they are represented in the target bundle » Reduce custom field grouping for products
Version: 7.x-1.0-beta4 » 7.x-1.x-dev
Status: Active » Needs review

Retitling.

dudenhofer’s picture

dudenhofer CreditAttribution: dudenhofer commented
Title: IEF should render fields as they are represented in the target bundle » Reduce custom field grouping for products

Just pushed an update to Shiny to account for this update without breaking previous versions. So you can test against the latest dev release soon.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Fixed

Thanks, Aaron. Looks good.

Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.